diff mbox series

[2/6] dt-bindings: rtc: nxp,pcf8563: Convert to DT schema

Message ID 20210518232858.1535403-3-robh@kernel.org
State New
Headers show
Series dt-bindings: Convert mux bindings to schema | expand

Commit Message

Rob Herring (Arm) May 18, 2021, 11:28 p.m. UTC
Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format.

Add 'interrupts' as this device has an interrupt which was not
documented, but in use.

Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Rob Herring <robh@kernel.org>

---
 .../devicetree/bindings/rtc/nxp,pcf8563.yaml  | 50 +++++++++++++++++++
 .../devicetree/bindings/rtc/pcf8563.txt       | 29 -----------
 2 files changed, 50 insertions(+), 29 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
 delete mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt

-- 
2.27.0

Comments

Laurent Pinchart May 19, 2021, 1:25 a.m. UTC | #1
Hi Rob,

Thank you for the patch.

On Tue, May 18, 2021 at 06:28:54PM -0500, Rob Herring wrote:
> Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format.

> 

> Add 'interrupts' as this device has an interrupt which was not

> documented, but in use.

> 

> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

> Signed-off-by: Rob Herring <robh@kernel.org>


Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


> ---

>  .../devicetree/bindings/rtc/nxp,pcf8563.yaml  | 50 +++++++++++++++++++

>  .../devicetree/bindings/rtc/pcf8563.txt       | 29 -----------

>  2 files changed, 50 insertions(+), 29 deletions(-)

>  create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml

>  delete mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt

> 

> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml

> new file mode 100644

> index 000000000000..15e67be0ef95

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml

> @@ -0,0 +1,50 @@

> +# SPDX-License-Identifier: GPL-2.0

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: Philips PCF8563/Epson RTC8564 Real Time Clock

> +

> +maintainers:

> +  - Alexandre Belloni <alexandre.belloni@bootlin.com>

> +

> +properties:

> +  compatible:

> +    enum:

> +      - epson,rtc8564

> +      - microcrystal,rv8564

> +      - nxp,pcf8563

> +      - nxp,pca8565

> +

> +  reg:

> +    maxItems: 1

> +

> +  "#clock-cells":

> +    const: 0

> +

> +  clock-output-names:

> +    maxItems: 1

> +

> +  interrupts:

> +    maxItems: 1

> +

> +required:

> +  - compatible

> +  - reg

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    i2c {

> +        #address-cells = <1>;

> +        #size-cells = <0>;

> +

> +        rtc@51 {

> +            compatible = "nxp,pcf8563";

> +            reg = <0x51>;

> +            #clock-cells = <0>;

> +        };

> +    };

> +...

> diff --git a/Documentation/devicetree/bindings/rtc/pcf8563.txt b/Documentation/devicetree/bindings/rtc/pcf8563.txt

> deleted file mode 100644

> index 0a900f7c8977..000000000000

> --- a/Documentation/devicetree/bindings/rtc/pcf8563.txt

> +++ /dev/null

> @@ -1,29 +0,0 @@

> -* Philips PCF8563/Epson RTC8564 Real Time Clock

> -

> -Philips PCF8563/Epson RTC8564 Real Time Clock

> -

> -Required properties:

> -- compatible: Should contain "nxp,pcf8563",

> -	"epson,rtc8564" or

> -	"microcrystal,rv8564" or

> -	"nxp,pca8565"

> -- reg: I2C address for chip.

> -

> -Optional property:

> -- #clock-cells: Should be 0.

> -- clock-output-names:

> -  overwrite the default clock name "pcf8563-clkout"

> -

> -Example:

> -

> -pcf8563: pcf8563@51 {

> -	compatible = "nxp,pcf8563";

> -	reg = <0x51>;

> -	#clock-cells = <0>;

> -};

> -

> -device {

> -...

> -	clocks = <&pcf8563>;

> -...

> -};


-- 
Regards,

Laurent Pinchart
Alexandre Belloni May 25, 2021, 9:27 p.m. UTC | #2
Hello,

On 18/05/2021 18:28:54-0500, Rob Herring wrote:
> Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format.

> 

> Add 'interrupts' as this device has an interrupt which was not

> documented, but in use.

> 


It also supports start-year from rtc.yaml.

> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  .../devicetree/bindings/rtc/nxp,pcf8563.yaml  | 50 +++++++++++++++++++

>  .../devicetree/bindings/rtc/pcf8563.txt       | 29 -----------

>  2 files changed, 50 insertions(+), 29 deletions(-)

>  create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml

>  delete mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt

> 

> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml

> new file mode 100644

> index 000000000000..15e67be0ef95

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml

> @@ -0,0 +1,50 @@

> +# SPDX-License-Identifier: GPL-2.0

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: Philips PCF8563/Epson RTC8564 Real Time Clock

> +

> +maintainers:

> +  - Alexandre Belloni <alexandre.belloni@bootlin.com>

> +

> +properties:

> +  compatible:

> +    enum:

> +      - epson,rtc8564

> +      - microcrystal,rv8564

> +      - nxp,pcf8563

> +      - nxp,pca8565

> +

> +  reg:

> +    maxItems: 1

> +

> +  "#clock-cells":

> +    const: 0

> +

> +  clock-output-names:

> +    maxItems: 1

> +

> +  interrupts:

> +    maxItems: 1

> +

> +required:

> +  - compatible

> +  - reg

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    i2c {

> +        #address-cells = <1>;

> +        #size-cells = <0>;

> +

> +        rtc@51 {

> +            compatible = "nxp,pcf8563";

> +            reg = <0x51>;

> +            #clock-cells = <0>;

> +        };

> +    };

> +...

> diff --git a/Documentation/devicetree/bindings/rtc/pcf8563.txt b/Documentation/devicetree/bindings/rtc/pcf8563.txt

> deleted file mode 100644

> index 0a900f7c8977..000000000000

> --- a/Documentation/devicetree/bindings/rtc/pcf8563.txt

> +++ /dev/null

> @@ -1,29 +0,0 @@

> -* Philips PCF8563/Epson RTC8564 Real Time Clock

> -

> -Philips PCF8563/Epson RTC8564 Real Time Clock

> -

> -Required properties:

> -- compatible: Should contain "nxp,pcf8563",

> -	"epson,rtc8564" or

> -	"microcrystal,rv8564" or

> -	"nxp,pca8565"

> -- reg: I2C address for chip.

> -

> -Optional property:

> -- #clock-cells: Should be 0.

> -- clock-output-names:

> -  overwrite the default clock name "pcf8563-clkout"

> -

> -Example:

> -

> -pcf8563: pcf8563@51 {

> -	compatible = "nxp,pcf8563";

> -	reg = <0x51>;

> -	#clock-cells = <0>;

> -};

> -

> -device {

> -...

> -	clocks = <&pcf8563>;

> -...

> -};

> -- 

> 2.27.0

> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Rob Herring (Arm) May 26, 2021, 5:06 p.m. UTC | #3
On Tue, May 25, 2021 at 4:27 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>

> Hello,

>

> On 18/05/2021 18:28:54-0500, Rob Herring wrote:

> > Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format.

> >

> > Add 'interrupts' as this device has an interrupt which was not

> > documented, but in use.

> >

>

> It also supports start-year from rtc.yaml.


And wakeup-source. I've added both.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
new file mode 100644
index 000000000000..15e67be0ef95
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
@@ -0,0 +1,50 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Philips PCF8563/Epson RTC8564 Real Time Clock
+
+maintainers:
+  - Alexandre Belloni <alexandre.belloni@bootlin.com>
+
+properties:
+  compatible:
+    enum:
+      - epson,rtc8564
+      - microcrystal,rv8564
+      - nxp,pcf8563
+      - nxp,pca8565
+
+  reg:
+    maxItems: 1
+
+  "#clock-cells":
+    const: 0
+
+  clock-output-names:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        rtc@51 {
+            compatible = "nxp,pcf8563";
+            reg = <0x51>;
+            #clock-cells = <0>;
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/rtc/pcf8563.txt b/Documentation/devicetree/bindings/rtc/pcf8563.txt
deleted file mode 100644
index 0a900f7c8977..000000000000
--- a/Documentation/devicetree/bindings/rtc/pcf8563.txt
+++ /dev/null
@@ -1,29 +0,0 @@ 
-* Philips PCF8563/Epson RTC8564 Real Time Clock
-
-Philips PCF8563/Epson RTC8564 Real Time Clock
-
-Required properties:
-- compatible: Should contain "nxp,pcf8563",
-	"epson,rtc8564" or
-	"microcrystal,rv8564" or
-	"nxp,pca8565"
-- reg: I2C address for chip.
-
-Optional property:
-- #clock-cells: Should be 0.
-- clock-output-names:
-  overwrite the default clock name "pcf8563-clkout"
-
-Example:
-
-pcf8563: pcf8563@51 {
-	compatible = "nxp,pcf8563";
-	reg = <0x51>;
-	#clock-cells = <0>;
-};
-
-device {
-...
-	clocks = <&pcf8563>;
-...
-};