MIPS: ralink: export rt_sysc_membase for rt2880_wdt.c

Message ID 20210517005417.18338-1-rdunlap@infradead.org
State New
Headers show
Series
  • MIPS: ralink: export rt_sysc_membase for rt2880_wdt.c
Related show

Commit Message

Randy Dunlap May 17, 2021, 12:54 a.m.
rt2880_wdt.c uses (well, attempts to use) rt_sysc_membase. However,
when this watchdog driver is built as a loadable module, there is a
build error since the rt_sysc_membase symbol is not exported.
Export it to quell the build error.

ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!

Fixes: 473cf939ff34 ("watchdog: add ralink watchdog driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: John Crispin <john@phrozen.org>
Cc: linux-mips@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org
---
or make the Kconfig symbol RALINK_WDT bool instead of tristate?

 arch/mips/ralink/of.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Bogendoerfer May 25, 2021, 1:39 p.m. | #1
On Sun, May 16, 2021 at 05:54:17PM -0700, Randy Dunlap wrote:
> rt2880_wdt.c uses (well, attempts to use) rt_sysc_membase. However,

> when this watchdog driver is built as a loadable module, there is a

> build error since the rt_sysc_membase symbol is not exported.

> Export it to quell the build error.

> 

> ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!

> 

> Fixes: 473cf939ff34 ("watchdog: add ralink watchdog driver")

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

> Cc: Guenter Roeck <linux@roeck-us.net>

> Cc: Wim Van Sebroeck <wim@iguana.be>

> Cc: John Crispin <john@phrozen.org>

> Cc: linux-mips@vger.kernel.org

> Cc: linux-watchdog@vger.kernel.org

> ---

> or make the Kconfig symbol RALINK_WDT bool instead of tristate?

> 

>  arch/mips/ralink/of.c |    2 ++

>  1 file changed, 2 insertions(+)


applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Patch

--- linux-next-20210514.orig/arch/mips/ralink/of.c
+++ linux-next-20210514/arch/mips/ralink/of.c
@@ -8,6 +8,7 @@ 
 
 #include <linux/io.h>
 #include <linux/clk.h>
+#include <linux/export.h>
 #include <linux/init.h>
 #include <linux/sizes.h>
 #include <linux/of_fdt.h>
@@ -25,6 +26,7 @@ 
 
 __iomem void *rt_sysc_membase;
 __iomem void *rt_memc_membase;
+EXPORT_SYMBOL_GPL(rt_sysc_membase);
 
 __iomem void *plat_of_remap_node(const char *node)
 {