| Message ID | 20210520190105.3772683-3-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | 45ce82f5eaedd5868b366d09d921a3205166d625 |
| Headers | show |
| Series | Rid W=1 warnings from I2C | expand |
Hi, On Thu, May 20, 2021 at 12:01 PM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:43: warning: Function parameter or member 'muxc' not described in 'i2c_arbitrator_select' > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:43: warning: Function parameter or member 'chan' not described in 'i2c_arbitrator_select' > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:86: warning: Function parameter or member 'muxc' not described in 'i2c_arbitrator_deselect' > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:86: warning: Function parameter or member 'chan' not described in 'i2c_arbitrator_deselect' > > Cc: Peter Rosin <peda@axentia.se> > Cc: Doug Anderson <dianders@chromium.org> > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/i2c/muxes/i2c-arb-gpio-challenge.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) No objections from me. Acked-by: Douglas Anderson <dianders@chromium.org> -Doug
Hi! On 2021-05-20 21:00, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:43: warning: Function parameter or member 'muxc' not described in 'i2c_arbitrator_select' > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:43: warning: Function parameter or member 'chan' not described in 'i2c_arbitrator_select' > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:86: warning: Function parameter or member 'muxc' not described in 'i2c_arbitrator_deselect' > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:86: warning: Function parameter or member 'chan' not described in 'i2c_arbitrator_deselect' > > Cc: Peter Rosin <peda@axentia.se> > Cc: Doug Anderson <dianders@chromium.org> > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Looks good, thanks! Acked-by: Peter Rosin <peda@axentia.se> Cheers, Peter
On Thu, May 20, 2021 at 08:00:51PM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:43: warning: Function parameter or member 'muxc' not described in 'i2c_arbitrator_select' > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:43: warning: Function parameter or member 'chan' not described in 'i2c_arbitrator_select' > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:86: warning: Function parameter or member 'muxc' not described in 'i2c_arbitrator_deselect' > drivers/i2c/muxes/i2c-arb-gpio-challenge.c:86: warning: Function parameter or member 'chan' not described in 'i2c_arbitrator_deselect' > > Cc: Peter Rosin <peda@axentia.se> > Cc: Doug Anderson <dianders@chromium.org> > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied to for-current, thanks!
diff --git a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c index 6dc88902c189f..1c78657631f4f 100644 --- a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c +++ b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c @@ -34,7 +34,7 @@ struct i2c_arbitrator_data { }; -/** +/* * i2c_arbitrator_select - claim the I2C bus * * Use the GPIO-based signalling protocol; return -EBUSY if we fail. @@ -77,7 +77,7 @@ static int i2c_arbitrator_select(struct i2c_mux_core *muxc, u32 chan) return -EBUSY; } -/** +/* * i2c_arbitrator_deselect - release the I2C bus * * Release the I2C bus using the GPIO-based signalling protocol.
Fixes the following W=1 kernel build warning(s): drivers/i2c/muxes/i2c-arb-gpio-challenge.c:43: warning: Function parameter or member 'muxc' not described in 'i2c_arbitrator_select' drivers/i2c/muxes/i2c-arb-gpio-challenge.c:43: warning: Function parameter or member 'chan' not described in 'i2c_arbitrator_select' drivers/i2c/muxes/i2c-arb-gpio-challenge.c:86: warning: Function parameter or member 'muxc' not described in 'i2c_arbitrator_deselect' drivers/i2c/muxes/i2c-arb-gpio-challenge.c:86: warning: Function parameter or member 'chan' not described in 'i2c_arbitrator_deselect' Cc: Peter Rosin <peda@axentia.se> Cc: Doug Anderson <dianders@chromium.org> Cc: linux-i2c@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/i2c/muxes/i2c-arb-gpio-challenge.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.31.1