diff mbox series

[08/16] i2c: busses: i2c-eg20t: Fix 'bad line' issue and provide description for 'msgs' param

Message ID 20210520190105.3772683-9-lee.jones@linaro.org
State Accepted
Commit f9f193fc222bd5352a414ba34406303cfedd2c5e
Headers show
Series Rid W=1 warnings from I2C | expand

Commit Message

Lee Jones May 20, 2021, 7 p.m. UTC 
Fixes the following W=1 kernel build warning(s):

 drivers/i2c/busses/i2c-eg20t.c:151: warning: bad line:                          PCH i2c controller
 drivers/i2c/busses/i2c-eg20t.c:369: warning: Function parameter or member 'msgs' not described in 'pch_i2c_writebytes'

Cc: Wolfram Sang <wsa@kernel.org>
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/i2c/busses/i2c-eg20t.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.31.1

Comments

Wolfram Sang May 27, 2021, 7:33 p.m. UTC | #1 
On Thu, May 20, 2021 at 08:00:57PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/i2c/busses/i2c-eg20t.c:151: warning: bad line:                          PCH i2c controller

>  drivers/i2c/busses/i2c-eg20t.c:369: warning: Function parameter or member 'msgs' not described in 'pch_i2c_writebytes'

> 

> Cc: Wolfram Sang <wsa@kernel.org>

> Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>

> Cc: Tomoya MORINAGA <tomoya.rohm@gmail.com>

> Cc: linux-i2c@vger.kernel.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Applied to for-current, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index 843b31a0f752b..321b2770feabc 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -148,7 +148,7 @@  struct i2c_algo_pch_data {
 
 /**
  * struct adapter_info - This structure holds the adapter information for the
-			 PCH i2c controller
+ *			 PCH i2c controller
  * @pch_data:		stores a list of i2c_algo_pch_data
  * @pch_i2c_suspended:	specifies whether the system is suspended or not
  *			perhaps with more lines and words.
@@ -358,6 +358,7 @@  static void pch_i2c_repstart(struct i2c_algo_pch_data *adap)
 /**
  * pch_i2c_writebytes() - write data to I2C bus in normal mode
  * @i2c_adap:	Pointer to the struct i2c_adapter.
+ * @msgs:	Pointer to the i2c message structure.
  * @last:	specifies whether last message or not.
  *		In the case of compound mode it will be 1 for last message,
  *		otherwise 0.