diff mbox series

[1/2] usb: gadget: tegra-xudc: Don't print error on probe deferral

Message ID 20210519163553.212682-1-jonathanh@nvidia.com
State New
Headers show
Series [1/2] usb: gadget: tegra-xudc: Don't print error on probe deferral | expand

Commit Message

Jon Hunter May 19, 2021, 4:35 p.m. UTC
The Tegra XUDC driver prints the following error when deferring probe
if the USB PHY is not found ...

 ERR KERN tegra-xudc 3550000.usb: failed to get usbphy-0: -517

Deferring probe can be normal and so update to driver to avoid printing
this error if probe is being deferred.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 drivers/usb/gadget/udc/tegra-xudc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Felipe Balbi June 3, 2021, 6:22 a.m. UTC | #1
Jon Hunter <jonathanh@nvidia.com> writes:

> The Tegra XUDC driver prints the following error when deferring probe

> if the USB PHY is not found ...

>

>  ERR KERN tegra-xudc 3550000.usb: failed to get usbphy-0: -517

>

> Deferring probe can be normal and so update to driver to avoid printing

> this error if probe is being deferred.

>

> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>


Acked-by: Felipe Balbi <balbi@kernel.org>


-- 
balbi
diff mbox series

Patch

diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
index 2319c9737c2b..a62bf095954b 100644
--- a/drivers/usb/gadget/udc/tegra-xudc.c
+++ b/drivers/usb/gadget/udc/tegra-xudc.c
@@ -3520,8 +3520,8 @@  static int tegra_xudc_phy_get(struct tegra_xudc *xudc)
 						&xudc->vbus_nb);
 			if (IS_ERR(xudc->usbphy[i])) {
 				err = PTR_ERR(xudc->usbphy[i]);
-				dev_err(xudc->dev, "failed to get usbphy-%d: %d\n",
-					i, err);
+				dev_err_probe(xudc->dev, err,
+					      "failed to get usbphy-%d\n", i);
 				goto clean_up;
 			}
 		} else if (!xudc->utmi_phy[i]) {