diff mbox

[1/6] linux-generic: imp.c: remove header defines from c file

Message ID 1423638605-6342-2-git-send-email-maxim.uvarov@linaro.org
State New
Headers show

Commit Message

Maxim Uvarov Feb. 11, 2015, 7:10 a.m. UTC 
Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
---
 platform/linux-generic/odp_impl.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Taras Kondratiuk Feb. 16, 2015, 10:59 a.m. UTC | #1 
On 02/11/2015 09:10 AM, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
>  platform/linux-generic/odp_impl.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/platform/linux-generic/odp_impl.c b/platform/linux-generic/odp_impl.c
> index ca3224d..f0a582e 100644
> --- a/platform/linux-generic/odp_impl.c
> +++ b/platform/linux-generic/odp_impl.c
> @@ -11,9 +11,6 @@
>   * ODP Implementation information
>   */
>  
> -#ifndef ODP_IMPL_H_
> -#define ODP_IMPL_H_
> -
>  #ifdef __cplusplus
>  extern "C" {
>  #endif

extern "C" should be also removed.

> @@ -31,5 +28,3 @@ const char *odp_version_impl_str(void)
>  #ifdef __cplusplus
>  }
>  #endif
> -
> -#endif
>
Maxim Uvarov Feb. 16, 2015, 11:54 a.m. UTC | #2 
On 02/16/2015 01:59 PM, Taras Kondratiuk wrote:
> On 02/11/2015 09:10 AM, Maxim Uvarov wrote:
>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
>> ---
>>   platform/linux-generic/odp_impl.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/platform/linux-generic/odp_impl.c b/platform/linux-generic/odp_impl.c
>> index ca3224d..f0a582e 100644
>> --- a/platform/linux-generic/odp_impl.c
>> +++ b/platform/linux-generic/odp_impl.c
>> @@ -11,9 +11,6 @@
>>    * ODP Implementation information
>>    */
>>   
>> -#ifndef ODP_IMPL_H_
>> -#define ODP_IMPL_H_
>> -
>>   #ifdef __cplusplus
>>   extern "C" {
>>   #endif
> extern "C" should be also removed.

obviously, yes.  It was removed in fist patch which includes everything. 
Will do it here. Thanks.

Maxim.

>
>> @@ -31,5 +28,3 @@ const char *odp_version_impl_str(void)
>>   #ifdef __cplusplus
>>   }
>>   #endif
>> -
>> -#endif
>>
>
diff mbox

Patch

diff --git a/platform/linux-generic/odp_impl.c b/platform/linux-generic/odp_impl.c
index ca3224d..f0a582e 100644
--- a/platform/linux-generic/odp_impl.c
+++ b/platform/linux-generic/odp_impl.c
@@ -11,9 +11,6 @@ 
  * ODP Implementation information
  */
 
-#ifndef ODP_IMPL_H_
-#define ODP_IMPL_H_
-
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -31,5 +28,3 @@  const char *odp_version_impl_str(void)
 #ifdef __cplusplus
 }
 #endif
-
-#endif