| Message ID | 20210522211055.15988-2-mirela.rabulea@oss.nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add dts and bindings update for i.MX8QM/QXP JPEG codec | expand |
> From: Mirela Rabulea (OSS) <mirela.rabulea@oss.nxp.com> > Sent: Sunday, May 23, 2021 5:11 AM > > Add two more compatibles: "nxp,imx8qm-jpgdec" and " nxp,imx8qm-jpgenc". > Also update the compatible property to ensure mutually exclusive usage of > encoder and decoder compatibles. > Update examples. > > Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> > --- > .../bindings/media/nxp,imx8-jpeg.yaml | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > index 5d13cbb5251b..5cc7b6a94c44 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > @@ -16,12 +16,15 @@ description: |- > > properties: > compatible: > - items: > - - enum: > - # JPEG decoder > - - nxp,imx8qxp-jpgdec > - # JPEG encoder > - - nxp,imx8qxp-jpgenc > + oneOf: > + - items: > + anyOf: > + - const: nxp,imx8qxp-jpgdec > + - const: nxp,imx8qm-jpgdec > + - items: > + anyOf: I might wish to avoid using anyOF for jpeg cases and defined in a more Straightforward way. e.g. properties: compatible: oneOf: - items: - enum: # JPEG decoder - nxp,imx8qxp-jpgdec # JPEG encoder - nxp,imx8qxp-jpgenc - items: - enum: - nxp,imx8qm-jpgdec - const: nxp,imx8qxp-jpgdec - items: - enum: - nxp,imx8qm-jpgenc - const: nxp,imx8qxp-jpgenc Could you check if it works? Regards Aisheng > + - const: nxp,imx8qxp-jpgenc > + - const: nxp,imx8qm-jpgenc > > reg: > maxItems: 1 > @@ -69,7 +72,7 @@ examples: > }; > > jpegenc: jpegenc@58450000 { > - compatible = "nxp,imx8qxp-jpgenc"; > + compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc"; > reg = <0x58450000 0x00050000 >; > interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>, > -- > 2.17.1
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml index 5d13cbb5251b..5cc7b6a94c44 100644 --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml @@ -16,12 +16,15 @@ description: |- properties: compatible: - items: - - enum: - # JPEG decoder - - nxp,imx8qxp-jpgdec - # JPEG encoder - - nxp,imx8qxp-jpgenc + oneOf: + - items: + anyOf: + - const: nxp,imx8qxp-jpgdec + - const: nxp,imx8qm-jpgdec + - items: + anyOf: + - const: nxp,imx8qxp-jpgenc + - const: nxp,imx8qm-jpgenc reg: maxItems: 1 @@ -69,7 +72,7 @@ examples: }; jpegenc: jpegenc@58450000 { - compatible = "nxp,imx8qxp-jpgenc"; + compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc"; reg = <0x58450000 0x00050000 >; interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,