[v2,2/6] dt-bindings: rtc: nxp,pcf8563: Convert to DT schema

Message ID 20210526184839.2937899-3-robh@kernel.org
State Accepted
Commit f743c41d00bea01bf3e5c79b1ae5dcebca8f8daa
Headers show
Series
  • dt-bindings: Convert mux bindings to schema
Related show

Commit Message

Rob Herring May 26, 2021, 6:48 p.m.
Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format.

Add 'interrupts' and 'wakeup-source' as this device has an interrupt
which was not documented, but in use. Add 'start-year' as well.

Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Signed-off-by: Rob Herring <robh@kernel.org>

---
v2:
 - Add reference to rtc.yaml and wakeup-source and start-year properties
---
 .../devicetree/bindings/rtc/nxp,pcf8563.yaml  | 56 +++++++++++++++++++
 .../devicetree/bindings/rtc/pcf8563.txt       | 29 ----------
 2 files changed, 56 insertions(+), 29 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
 delete mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt

-- 
2.27.0

Comments

Alexandre Belloni May 26, 2021, 7:56 p.m. | #1
On 26/05/2021 13:48:35-0500, Rob Herring wrote:
> Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format.

> 

> Add 'interrupts' and 'wakeup-source' as this device has an interrupt

> which was not documented, but in use. Add 'start-year' as well.

> 

> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>


> ---

> v2:

>  - Add reference to rtc.yaml and wakeup-source and start-year properties

> ---

>  .../devicetree/bindings/rtc/nxp,pcf8563.yaml  | 56 +++++++++++++++++++

>  .../devicetree/bindings/rtc/pcf8563.txt       | 29 ----------

>  2 files changed, 56 insertions(+), 29 deletions(-)

>  create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml

>  delete mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt

> 

> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml

> new file mode 100644

> index 000000000000..a542b6c7ff44

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml

> @@ -0,0 +1,56 @@

> +# SPDX-License-Identifier: GPL-2.0

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: Philips PCF8563/Epson RTC8564 Real Time Clock

> +

> +maintainers:

> +  - Alexandre Belloni <alexandre.belloni@bootlin.com>

> +

> +allOf:

> +  - $ref: rtc.yaml#

> +

> +properties:

> +  compatible:

> +    enum:

> +      - epson,rtc8564

> +      - microcrystal,rv8564

> +      - nxp,pcf8563

> +      - nxp,pca8565

> +

> +  reg:

> +    maxItems: 1

> +

> +  "#clock-cells":

> +    const: 0

> +

> +  clock-output-names:

> +    maxItems: 1

> +

> +  interrupts:

> +    maxItems: 1

> +

> +  start-year: true

> +  wakeup-source: true

> +

> +required:

> +  - compatible

> +  - reg

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    i2c {

> +        #address-cells = <1>;

> +        #size-cells = <0>;

> +

> +        rtc@51 {

> +            compatible = "nxp,pcf8563";

> +            reg = <0x51>;

> +            #clock-cells = <0>;

> +        };

> +    };

> +...

> diff --git a/Documentation/devicetree/bindings/rtc/pcf8563.txt b/Documentation/devicetree/bindings/rtc/pcf8563.txt

> deleted file mode 100644

> index 0a900f7c8977..000000000000

> --- a/Documentation/devicetree/bindings/rtc/pcf8563.txt

> +++ /dev/null

> @@ -1,29 +0,0 @@

> -* Philips PCF8563/Epson RTC8564 Real Time Clock

> -

> -Philips PCF8563/Epson RTC8564 Real Time Clock

> -

> -Required properties:

> -- compatible: Should contain "nxp,pcf8563",

> -	"epson,rtc8564" or

> -	"microcrystal,rv8564" or

> -	"nxp,pca8565"

> -- reg: I2C address for chip.

> -

> -Optional property:

> -- #clock-cells: Should be 0.

> -- clock-output-names:

> -  overwrite the default clock name "pcf8563-clkout"

> -

> -Example:

> -

> -pcf8563: pcf8563@51 {

> -	compatible = "nxp,pcf8563";

> -	reg = <0x51>;

> -	#clock-cells = <0>;

> -};

> -

> -device {

> -...

> -	clocks = <&pcf8563>;

> -...

> -};

> -- 

> 2.27.0

> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Patch

diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
new file mode 100644
index 000000000000..a542b6c7ff44
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
@@ -0,0 +1,56 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Philips PCF8563/Epson RTC8564 Real Time Clock
+
+maintainers:
+  - Alexandre Belloni <alexandre.belloni@bootlin.com>
+
+allOf:
+  - $ref: rtc.yaml#
+
+properties:
+  compatible:
+    enum:
+      - epson,rtc8564
+      - microcrystal,rv8564
+      - nxp,pcf8563
+      - nxp,pca8565
+
+  reg:
+    maxItems: 1
+
+  "#clock-cells":
+    const: 0
+
+  clock-output-names:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  start-year: true
+  wakeup-source: true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        rtc@51 {
+            compatible = "nxp,pcf8563";
+            reg = <0x51>;
+            #clock-cells = <0>;
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/rtc/pcf8563.txt b/Documentation/devicetree/bindings/rtc/pcf8563.txt
deleted file mode 100644
index 0a900f7c8977..000000000000
--- a/Documentation/devicetree/bindings/rtc/pcf8563.txt
+++ /dev/null
@@ -1,29 +0,0 @@ 
-* Philips PCF8563/Epson RTC8564 Real Time Clock
-
-Philips PCF8563/Epson RTC8564 Real Time Clock
-
-Required properties:
-- compatible: Should contain "nxp,pcf8563",
-	"epson,rtc8564" or
-	"microcrystal,rv8564" or
-	"nxp,pca8565"
-- reg: I2C address for chip.
-
-Optional property:
-- #clock-cells: Should be 0.
-- clock-output-names:
-  overwrite the default clock name "pcf8563-clkout"
-
-Example:
-
-pcf8563: pcf8563@51 {
-	compatible = "nxp,pcf8563";
-	reg = <0x51>;
-	#clock-cells = <0>;
-};
-
-device {
-...
-	clocks = <&pcf8563>;
-...
-};