i2c: i801: Use driver name constant instead of function dev_driver_string

Message ID 089c47ad-1519-947e-ac31-290da37159d7@gmail.com
State New
Headers show
Series
  • i2c: i801: Use driver name constant instead of function dev_driver_string
Related show

Commit Message

Heiner Kallweit May 25, 2021, 8:04 p.m.
We are the driver, so we can use the driver name directly instead of
retrieving it by calling dev_driver_string().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/i2c/busses/i2c-i801.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Jean Delvare June 14, 2021, 4:27 p.m. | #1
On Tue, 25 May 2021 22:04:23 +0200, Heiner Kallweit wrote:
> We are the driver, so we can use the driver name directly instead of

> retrieving it by calling dev_driver_string().


Makes sense. Should make the code slightly faster.

> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

> ---

>  drivers/i2c/busses/i2c-i801.c | 10 +++++-----

>  1 file changed, 5 insertions(+), 5 deletions(-)

> (...)


Reviewed-by: Jean Delvare <jdelvare@suse.de>

Tested-by: Jean Delvare <jdelvare@suse.de>


-- 
Jean Delvare
SUSE L3 Support
Wolfram Sang June 20, 2021, 8:55 p.m. | #2
On Tue, May 25, 2021 at 10:04:23PM +0200, Heiner Kallweit wrote:
> We are the driver, so we can use the driver name directly instead of

> retrieving it by calling dev_driver_string().

> 

> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>


Applied to for-next, thanks!

Patch

diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 047f73f1a..5a7ce2658 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -88,6 +88,8 @@ 
  * See the file Documentation/i2c/busses/i2c-i801.rst for details.
  */
 
+#define DRV_NAME	"i801_smbus"
+
 #include <linux/interrupt.h>
 #include <linux/module.h>
 #include <linux/pci.h>
@@ -1813,8 +1815,7 @@  static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
 	if (i801_acpi_probe(priv))
 		return -ENODEV;
 
-	err = pcim_iomap_regions(dev, 1 << SMBBAR,
-				 dev_driver_string(&dev->dev));
+	err = pcim_iomap_regions(dev, 1 << SMBBAR, DRV_NAME);
 	if (err) {
 		dev_err(&dev->dev,
 			"Failed to request SMBus region 0x%lx-0x%Lx\n",
@@ -1872,8 +1873,7 @@  static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
 		init_completion(&priv->done);
 
 		err = devm_request_irq(&dev->dev, dev->irq, i801_isr,
-				       IRQF_SHARED,
-				       dev_driver_string(&dev->dev), priv);
+				       IRQF_SHARED, DRV_NAME, priv);
 		if (err) {
 			dev_err(&dev->dev, "Failed to allocate irq %d: %d\n",
 				dev->irq, err);
@@ -1963,7 +1963,7 @@  static int i801_resume(struct device *dev)
 static SIMPLE_DEV_PM_OPS(i801_pm_ops, i801_suspend, i801_resume);
 
 static struct pci_driver i801_driver = {
-	.name		= "i801_smbus",
+	.name		= DRV_NAME,
 	.id_table	= i801_ids,
 	.probe		= i801_probe,
 	.remove		= i801_remove,