| Message ID | 1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | ath10k: Fix an error code in ath10k_add_interface() | expand |
Yang Li <yang.lee@linux.alibaba.com> wrote: > When the code execute this if statement, the value of ret is 0. > However, we can see from the ath10k_warn() log that the value of > ret should be -EINVAL. > > Clean up smatch warning: > > drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn: > missing error code 'ret' > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Fixes: 'commit ccec9038c721 ("ath10k: enable raw encap mode and software > crypto engine")' > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Fixes tag is wrong, it should be: Fixes: ccec9038c721 ("ath10k: enable raw encap mode and software crypto engine") I fixed this in the pending branch, no need to resend because of this. -- https://patchwork.kernel.org/project/linux-wireless/patch/1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Yang Li <yang.lee@linux.alibaba.com> wrote: > When the code execute this if statement, the value of ret is 0. > However, we can see from the ath10k_warn() log that the value of > ret should be -EINVAL. > > Clean up smatch warning: > > drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn: > missing error code 'ret' > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Fixes: ccec9038c721 ("ath10k: enable raw encap mode and software crypto engine") > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. e9ca70c735ce ath10k: Fix an error code in ath10k_add_interface() -- https://patchwork.kernel.org/project/linux-wireless/patch/1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 5ce4f8d..c272b29 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -5592,6 +5592,7 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, if (arvif->nohwcrypt && !test_bit(ATH10K_FLAG_RAW_MODE, &ar->dev_flags)) { + ret = -EINVAL; ath10k_warn(ar, "cryptmode module param needed for sw crypto\n"); goto err; }
When the code execute this if statement, the value of ret is 0. However, we can see from the ath10k_warn() log that the value of ret should be -EINVAL. Clean up smatch warning: drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn: missing error code 'ret' Reported-by: Abaci Robot <abaci@linux.alibaba.com> Fixes: 'commit ccec9038c721 ("ath10k: enable raw encap mode and software crypto engine")' Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/wireless/ath/ath10k/mac.c | 1 + 1 file changed, 1 insertion(+)