From patchwork Tue Feb 24 12:13:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Semwal X-Patchwork-Id: 44936 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f200.google.com (mail-wi0-f200.google.com [209.85.212.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 7308E2029F for ; Tue, 24 Feb 2015 12:14:05 +0000 (UTC) Received: by mail-wi0-f200.google.com with SMTP id r20sf14653014wiv.3 for ; Tue, 24 Feb 2015 04:14:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=YwILJyr8GTkxCG1fRokfj7X30vL182pJx7OmpRnyy3c=; b=GhpbX0/lh2QzRKrwKMjkN/dGeef+45iYOctvqzhsU5Kt4MEhoo+ruCFb4srFpRVzxz mwfuP+YQLNbFKV41Wjq0e/xZKFXZWMumYsvy5zl9BWY+g1RDDjaJ5zmxs/ClWkxUQZDs BriH/tya9iIAW2sKlEjR5rB2di5Caw91TR6tL03IRITSM49PUKsmC/1alnPG3MZXGQ+0 IGt0RQ9zzYb+SOhGpCebhiebKTbuiZc/gBuK+LaJ6Y1hs08At3pMa1EKCwLOvtSSihPV 05c1C309Xc4IuwlWGctPwfvvJUiXprzh/HKAgMIHBJoSGEw0arF6cHj1OYo7sPmXJuXa 8Jqw== X-Gm-Message-State: ALoCoQk20h3oDIyCM4tLTVnJJsy/GQ0dHfKg/3lfVBPyTIbiWBYUt+TwV/QXQYmBstBUmqQYWdbe X-Received: by 10.112.161.9 with SMTP id xo9mr2106892lbb.7.1424780044721; Tue, 24 Feb 2015 04:14:04 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.43.98 with SMTP id v2ls604465lal.104.gmail; Tue, 24 Feb 2015 04:14:04 -0800 (PST) X-Received: by 10.112.12.134 with SMTP id y6mr14406661lbb.34.1424780044415; Tue, 24 Feb 2015 04:14:04 -0800 (PST) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com. [209.85.217.181]) by mx.google.com with ESMTPS id wy5si8973336lbb.140.2015.02.24.04.14.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 04:14:04 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) client-ip=209.85.217.181; Received: by lbjb6 with SMTP id b6so24499813lbj.2 for ; Tue, 24 Feb 2015 04:14:04 -0800 (PST) X-Received: by 10.152.26.199 with SMTP id n7mr13937662lag.29.1424780044099; Tue, 24 Feb 2015 04:14:04 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp1869393lbj; Tue, 24 Feb 2015 04:14:03 -0800 (PST) X-Received: by 10.70.89.200 with SMTP id bq8mr28371587pdb.57.1424780041636; Tue, 24 Feb 2015 04:14:01 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id iw9si3184205pbc.248.2015.02.24.04.14.00; Tue, 24 Feb 2015 04:14:01 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752711AbbBXMN4 (ORCPT + 28 others); Tue, 24 Feb 2015 07:13:56 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:39800 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbbBXMNz (ORCPT ); Tue, 24 Feb 2015 07:13:55 -0500 Received: by pablf10 with SMTP id lf10so35633131pab.6 for ; Tue, 24 Feb 2015 04:13:54 -0800 (PST) X-Received: by 10.68.239.4 with SMTP id vo4mr3177191pbc.14.1424780034657; Tue, 24 Feb 2015 04:13:54 -0800 (PST) Received: from ss-ubuntu.lan ([106.51.225.38]) by mx.google.com with ESMTPSA id bh15sm30584637pdb.21.2015.02.24.04.13.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 Feb 2015 04:13:54 -0800 (PST) From: Sumit Semwal To: linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dan.carpenter@oracle.com, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, Sumit Semwal Subject: [PATCH] staging: android: ion: fix wrong init of dma_buf_export_info Date: Tue, 24 Feb 2015 17:43:25 +0530 Message-Id: <1424780005-13966-1-git-send-email-sumit.semwal@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sumit.semwal@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Fixes: 817bd7253291 ("dma-buf: cleanup dma_buf_export() to make it easily extensible") Stupid copy-paste from me in the above patch leads to the following static checker warning: drivers/staging/android/ion/ion.c:1112 ion_share_dma_buf() error: potentially dereferencing uninitialized 'buffer'. drivers/staging/android/ion/ion.c 1103 struct dma_buf *ion_share_dma_buf(struct ion_client *client, 1104 struct ion_handle *handle) 1105 { 1106 struct ion_buffer *buffer; ^^^^^^ 1107 struct dma_buf *dmabuf; 1108 bool valid_handle; 1109 DEFINE_DMA_BUF_EXPORT_INFO(exp_info); 1110 1111 exp_info.ops = &dma_buf_ops; 1112 exp_info.size = buffer->size; ^^^^^^ 1113 exp_info.flags = O_RDWR; 1114 exp_info.priv = buffer; ^^^^^^ And here also. 1115 This patch corrects this stupidity. Reported-by: Dan Carpenter Signed-off-by: Sumit Semwal --- drivers/staging/android/ion/ion.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index a4297be8f12f..204860a36c29 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -1108,11 +1108,6 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client, bool valid_handle; DEFINE_DMA_BUF_EXPORT_INFO(exp_info); - exp_info.ops = &dma_buf_ops; - exp_info.size = buffer->size; - exp_info.flags = O_RDWR; - exp_info.priv = buffer; - mutex_lock(&client->lock); valid_handle = ion_handle_validate(client, handle); if (!valid_handle) { @@ -1124,6 +1119,11 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client, ion_buffer_get(buffer); mutex_unlock(&client->lock); + exp_info.ops = &dma_buf_ops; + exp_info.size = buffer->size; + exp_info.flags = O_RDWR; + exp_info.priv = buffer; + dmabuf = dma_buf_export(&exp_info); if (IS_ERR(dmabuf)) { ion_buffer_put(buffer);