| Message ID | 1424871377-1795-5-git-send-email-peter.griffin@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Wed, 25 Feb 2015, Peter Griffin wrote: > Now that both usb2 and usb3 phy drivers, and also the ST dwc3 glue code > are all present upstream, we can add the dwc3 DT node and have a working > usb3 controller on stih407-b2120 and stih410-b2020. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > index 186412d..18ff5a5 100644 > --- a/arch/arm/boot/dts/stih407-family.dtsi > +++ b/arch/arm/boot/dts/stih407-family.dtsi > @@ -7,6 +7,7 @@ > * publishhed by the Free Software Foundation. > */ > #include "stih407-pinctrl.dtsi" > +#include <dt-bindings/phy/phy.h> > #include <dt-bindings/reset-controller/stih407-resets.h> > / { > #address-cells = <1>; > @@ -336,5 +337,30 @@ > resets = <&softreset STIH407_MIPHY2_SOFTRESET>; > }; > }; > + > + st_dwc3: dwc3@8f94000 { > + compatible = "st,stih407-dwc3"; > + reg = <0x08f94000 0x1000>, <0x110 0x4>; > + reg-names = "reg-glue", "syscfg-reg"; > + st,syscfg = <&syscfg_core>; > + resets = <&powerdown STIH407_USB3_POWERDOWN>, > + <&softreset STIH407_MIPHY2_SOFTRESET>; > + reset-names = "powerdown", > + "softreset"; Nit: What's the purpose of having these on separate lines? Apart from that, it looks good: Acked-by: Lee Jones <lee.jones@linaro.org> > + #address-cells = <1>; > + #size-cells = <1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb3>; > + ranges; > + > + dwc3: dwc3@9900000 { > + compatible = "snps,dwc3"; > + reg = <0x09900000 0x100000>; > + interrupts = <GIC_SPI 155 IRQ_TYPE_NONE>; > + dr_mode = "host"; > + phy-names = "usb2-phy", "usb3-phy"; > + phys = <&usb2_picophy0>, <&phy_port2 PHY_TYPE_USB3>; > + }; > + }; > }; > };
Hi Lee, On Wed, 25 Feb 2015, Lee Jones wrote: > > + resets = <&powerdown STIH407_USB3_POWERDOWN>, > > + <&softreset STIH407_MIPHY2_SOFTRESET>; > > + reset-names = "powerdown", > > + "softreset"; > > Nit: What's the purpose of having these on separate lines? The only reason was to stay aligned with the example in Documentation/devicetree/bindings/usb/dwc3-st.txt. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 25 Feb 2015, Peter Griffin wrote: > Hi Lee, > > On Wed, 25 Feb 2015, Lee Jones wrote: > > > > + resets = <&powerdown STIH407_USB3_POWERDOWN>, > > > + <&softreset STIH407_MIPHY2_SOFTRESET>; > > > + reset-names = "powerdown", > > > + "softreset"; > > > > Nit: What's the purpose of having these on separate lines? > > The only reason was to stay aligned with the example in > Documentation/devicetree/bindings/usb/dwc3-st.txt. But didn't you author that too? :) I would change them both. No need to force a line wrap if it's not required.
Hi Lee, On Wed, 25 Feb 2015, Lee Jones wrote: > > > > + reset-names = "powerdown", > > > > + "softreset"; > > > > > > Nit: What's the purpose of having these on separate lines? > > > > The only reason was to stay aligned with the example in > > Documentation/devicetree/bindings/usb/dwc3-st.txt. > > But didn't you author that too? :) Yep > > I would change them both. No need to force a line wrap if it's not required. Ok, I'll remove it from both in v2, whilst adding the acks. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi index 186412d..18ff5a5 100644 --- a/arch/arm/boot/dts/stih407-family.dtsi +++ b/arch/arm/boot/dts/stih407-family.dtsi @@ -7,6 +7,7 @@ * publishhed by the Free Software Foundation. */ #include "stih407-pinctrl.dtsi" +#include <dt-bindings/phy/phy.h> #include <dt-bindings/reset-controller/stih407-resets.h> / { #address-cells = <1>; @@ -336,5 +337,30 @@ resets = <&softreset STIH407_MIPHY2_SOFTRESET>; }; }; + + st_dwc3: dwc3@8f94000 { + compatible = "st,stih407-dwc3"; + reg = <0x08f94000 0x1000>, <0x110 0x4>; + reg-names = "reg-glue", "syscfg-reg"; + st,syscfg = <&syscfg_core>; + resets = <&powerdown STIH407_USB3_POWERDOWN>, + <&softreset STIH407_MIPHY2_SOFTRESET>; + reset-names = "powerdown", + "softreset"; + #address-cells = <1>; + #size-cells = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb3>; + ranges; + + dwc3: dwc3@9900000 { + compatible = "snps,dwc3"; + reg = <0x09900000 0x100000>; + interrupts = <GIC_SPI 155 IRQ_TYPE_NONE>; + dr_mode = "host"; + phy-names = "usb2-phy", "usb3-phy"; + phys = <&usb2_picophy0>, <&phy_port2 PHY_TYPE_USB3>; + }; + }; }; };
Now that both usb2 and usb3 phy drivers, and also the ST dwc3 glue code are all present upstream, we can add the dwc3 DT node and have a working usb3 controller on stih407-b2120 and stih410-b2020. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)