scsi: libsas: Use fallthrough pseudo-keyword

Message ID 20210531153724.3149-1-jj251510319013@gmail.com
State New
Headers show
Series
  • scsi: libsas: Use fallthrough pseudo-keyword
Related show

Commit Message

Wei Ming Chen May 31, 2021, 3:37 p.m.
Replace /* Fall through */ comment with pseudo-keyword macro fallthrough[1]

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
---
 drivers/scsi/libsas/sas_discover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John Garry June 1, 2021, 8:16 a.m. | #1
+ Gustavo

On 31/05/2021 16:37, Wei Ming Chen wrote:
> Replace /* Fall through */ comment with pseudo-keyword macro fallthrough[1]

> 

> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

> 

> Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>

> ---

>   drivers/scsi/libsas/sas_discover.c | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c

> index 9f5068f3bcfb..dd205414e505 100644

> --- a/drivers/scsi/libsas/sas_discover.c

> +++ b/drivers/scsi/libsas/sas_discover.c

> @@ -461,7 +461,7 @@ static void sas_discover_domain(struct work_struct *work)

>   		break;

>   #else

>   		pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");

> -		/* Fall through */

> +		fallthrough;


I don't know why we need the 2nd fall through (and the compiler can't 
see the first one) - added by Gustavo in da1fb2909 - but I think that 
this one can now simply be removed.

>   #endif

>   		/* Fall through - only for the #else condition above. */

Thanks,
John

>   	default:

>

Patch

diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
index 9f5068f3bcfb..dd205414e505 100644
--- a/drivers/scsi/libsas/sas_discover.c
+++ b/drivers/scsi/libsas/sas_discover.c
@@ -461,7 +461,7 @@  static void sas_discover_domain(struct work_struct *work)
 		break;
 #else
 		pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");
-		/* Fall through */
+		fallthrough;
 #endif
 		/* Fall through - only for the #else condition above. */
 	default: