| Message ID | 20210601184417.3020834-1-swboyd@chromium.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: Disable PON on Trogdor | expand |
Hi, On Tue, Jun 1, 2021 at 11:44 AM Stephen Boyd <swboyd@chromium.org> wrote: > > We don't use the PON module on Trogdor devices. Instead the reboot > reason is sort of stored in the 'eventlog' and the bootloader figures > out if the boot is abnormal and records that there. Disable the PON node > and then drop the power key disabling because that's a child node that > will no longer be enabled if the PON node is disabled. > > Cc: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Right. So essentially you're saying that the bootloader on trogdor (coreboot / depthcharge) doesn't do anything with this and thus it doesn't make sense on this board. That sounds right to me. Basically there's no way in userspace to tell the bootloader to reboot into recovery mode or developer mode. Those things need to be initiated manually by the user. It's possible that Qualcomm internally has some out-of-tree patches where they use the PON for ramdump mode. +Rajendra as an FYI in case there's somehow he should give a heads up to about this. Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Tue, 1 Jun 2021 11:44:17 -0700 you wrote: > We don't use the PON module on Trogdor devices. Instead the reboot > reason is sort of stored in the 'eventlog' and the bootloader figures > out if the boot is abnormal and records that there. Disable the PON node > and then drop the power key disabling because that's a child node that > will no longer be enabled if the PON node is disabled. > > Cc: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > [...] Here is the summary with links: - arm64: dts: qcom: Disable PON on Trogdor https://git.kernel.org/qcom/c/d141e0524e8e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 24d293ef56d7..cbde625cbea2 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -805,7 +805,7 @@ charger-thermistor@0 { }; }; -&pm6150_pwrkey { +&pm6150_pon { status = "disabled"; };
We don't use the PON module on Trogdor devices. Instead the reboot reason is sort of stored in the 'eventlog' and the bootloader figures out if the boot is abnormal and records that there. Disable the PON node and then drop the power key disabling because that's a child node that will no longer be enabled if the PON node is disabled. Cc: Douglas Anderson <dianders@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: d07f6ca923ea0927a1024dfccafc5b53b61cfecc