[RESEND,09/26] drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc'

Message ID 20210602143300.2330146-10-lee.jones@linaro.org
State New
Headers show
Series
  • Rid W=1 warnings from GPU
Related show

Commit Message

Lee Jones June 2, 2021, 2:32 p.m.
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning: variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable]

Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
 1 file changed, 4 deletions(-)

-- 
2.31.1

Comments

Abhinav Kumar June 2, 2021, 5:26 p.m. | #1
On 2021-06-02 07:32, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function

> ‘dpu_encoder_phys_cmd_wait_for_commit_done’:

>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:

> variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable]

> 

> Cc: Rob Clark <robdclark@gmail.com>

> Cc: Sean Paul <sean@poorly.run>

> Cc: David Airlie <airlied@linux.ie>

> Cc: Daniel Vetter <daniel@ffwll.ch>

> Cc: AngeloGioacchino Del Regno 

> <angelogioacchino.delregno@somainline.org>

> Cc: linux-arm-msm@vger.kernel.org

> Cc: dri-devel@lists.freedesktop.org

> Cc: freedreno@lists.freedesktop.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>

> ---

>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----

>  1 file changed, 4 deletions(-)

> 

> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c

> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c

> index b2be39b9144e4..088900841bf8b 100644

> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c

> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c

> @@ -685,10 +685,6 @@ static int 

> dpu_encoder_phys_cmd_wait_for_tx_complete(

>  static int dpu_encoder_phys_cmd_wait_for_commit_done(

>  		struct dpu_encoder_phys *phys_enc)

>  {

> -	struct dpu_encoder_phys_cmd *cmd_enc;

> -

> -	cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);

> -

>  	/* only required for master controller */

>  	if (!dpu_encoder_phys_cmd_is_master(phys_enc))

>  		return 0;

Patch

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
index b2be39b9144e4..088900841bf8b 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
@@ -685,10 +685,6 @@  static int dpu_encoder_phys_cmd_wait_for_tx_complete(
 static int dpu_encoder_phys_cmd_wait_for_commit_done(
 		struct dpu_encoder_phys *phys_enc)
 {
-	struct dpu_encoder_phys_cmd *cmd_enc;
-
-	cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
-
 	/* only required for master controller */
 	if (!dpu_encoder_phys_cmd_is_master(phys_enc))
 		return 0;