diff mbox series

[RESEND,14/26] drm/msm/dp/dp_link: Fix some potential doc-rot

Message ID 20210602143300.2330146-15-lee.jones@linaro.org
State Accepted
Commit 44b4fcbc455356f00b7681220b43b75914abfe3a
Headers show
Series Rid W=1 warnings from GPU | expand

Commit Message

Lee Jones June 2, 2021, 2:32 p.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/msm/dp/dp_link.c:374: warning: expecting prototype for dp_parse_video_pattern_params(). Prototype was for dp_link_parse_video_pattern_params() instead
 drivers/gpu/drm/msm/dp/dp_link.c:573: warning: expecting prototype for dp_parse_phy_test_params(). Prototype was for dp_link_parse_phy_test_params() instead
 drivers/gpu/drm/msm/dp/dp_link.c:975: warning: expecting prototype for dp_link_process_downstream_port_status_change(). Prototype was for dp_link_process_ds_port_status_change() instead

Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Chandan Uddaraju <chandanu@codeaurora.org>
Cc: Kuogee Hsieh <khsieh@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/gpu/drm/msm/dp/dp_link.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.31.1

Comments

Dmitry Baryshkov June 4, 2021, 12:51 a.m. UTC | #1
On 02/06/2021 17:32, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>   drivers/gpu/drm/msm/dp/dp_link.c:374: warning: expecting prototype for dp_parse_video_pattern_params(). Prototype was for dp_link_parse_video_pattern_params() instead

>   drivers/gpu/drm/msm/dp/dp_link.c:573: warning: expecting prototype for dp_parse_phy_test_params(). Prototype was for dp_link_parse_phy_test_params() instead

>   drivers/gpu/drm/msm/dp/dp_link.c:975: warning: expecting prototype for dp_link_process_downstream_port_status_change(). Prototype was for dp_link_process_ds_port_status_change() instead

> 

> Cc: Rob Clark <robdclark@gmail.com>

> Cc: Sean Paul <sean@poorly.run>

> Cc: David Airlie <airlied@linux.ie>

> Cc: Daniel Vetter <daniel@ffwll.ch>

> Cc: Chandan Uddaraju <chandanu@codeaurora.org>

> Cc: Kuogee Hsieh <khsieh@codeaurora.org>

> Cc: linux-arm-msm@vger.kernel.org

> Cc: dri-devel@lists.freedesktop.org

> Cc: freedreno@lists.freedesktop.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


> ---

>   drivers/gpu/drm/msm/dp/dp_link.c | 6 +++---

>   1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c

> index be986da78c4a5..1099604bd1c86 100644

> --- a/drivers/gpu/drm/msm/dp/dp_link.c

> +++ b/drivers/gpu/drm/msm/dp/dp_link.c

> @@ -364,7 +364,7 @@ static int dp_link_parse_timing_params3(struct dp_link_private *link,

>   }

>   

>   /**

> - * dp_parse_video_pattern_params() - parses video pattern parameters from DPCD

> + * dp_link_parse_video_pattern_params() - parses video pattern parameters from DPCD

>    * @link: Display Port Driver data

>    *

>    * Returns 0 if it successfully parses the video link pattern and the link

> @@ -563,7 +563,7 @@ static int dp_link_parse_link_training_params(struct dp_link_private *link)

>   }

>   

>   /**

> - * dp_parse_phy_test_params() - parses the phy link parameters

> + * dp_link_parse_phy_test_params() - parses the phy link parameters

>    * @link: Display Port Driver data

>    *

>    * Parses the DPCD (Byte 0x248) for the DP PHY link pattern that is being

> @@ -961,7 +961,7 @@ static int dp_link_process_link_status_update(struct dp_link_private *link)

>   }

>   

>   /**

> - * dp_link_process_downstream_port_status_change() - process port status changes

> + * dp_link_process_ds_port_status_change() - process port status changes

>    * @link: Display Port Driver data

>    *

>    * This function will handle downstream port updates that are initiated by

> 



-- 
With best wishes
Dmitry
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
index be986da78c4a5..1099604bd1c86 100644
--- a/drivers/gpu/drm/msm/dp/dp_link.c
+++ b/drivers/gpu/drm/msm/dp/dp_link.c
@@ -364,7 +364,7 @@  static int dp_link_parse_timing_params3(struct dp_link_private *link,
 }
 
 /**
- * dp_parse_video_pattern_params() - parses video pattern parameters from DPCD
+ * dp_link_parse_video_pattern_params() - parses video pattern parameters from DPCD
  * @link: Display Port Driver data
  *
  * Returns 0 if it successfully parses the video link pattern and the link
@@ -563,7 +563,7 @@  static int dp_link_parse_link_training_params(struct dp_link_private *link)
 }
 
 /**
- * dp_parse_phy_test_params() - parses the phy link parameters
+ * dp_link_parse_phy_test_params() - parses the phy link parameters
  * @link: Display Port Driver data
  *
  * Parses the DPCD (Byte 0x248) for the DP PHY link pattern that is being
@@ -961,7 +961,7 @@  static int dp_link_process_link_status_update(struct dp_link_private *link)
 }
 
 /**
- * dp_link_process_downstream_port_status_change() - process port status changes
+ * dp_link_process_ds_port_status_change() - process port status changes
  * @link: Display Port Driver data
  *
  * This function will handle downstream port updates that are initiated by