[RESEND,18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()'

Message ID 20210602143300.2330146-19-lee.jones@linaro.org
State New
Headers show
Series
  • Rid W=1 warnings from GPU
Related show

Commit Message

Lee Jones June 2, 2021, 2:32 p.m.
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/xlnx/zynqmp_dp.c:806: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead

Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.31.1

Comments

Laurent Pinchart June 2, 2021, 4:23 p.m. | #1
Hi Lee,

Thank you for the patch.

On Wed, Jun 02, 2021 at 03:32:52PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/gpu/drm/xlnx/zynqmp_dp.c:806: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead

> 

> Cc: Hyun Kwon <hyun.kwon@xilinx.com>

> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Cc: David Airlie <airlied@linux.ie>

> Cc: Daniel Vetter <daniel@ffwll.ch>

> Cc: Michal Simek <michal.simek@xilinx.com>

> Cc: Philipp Zabel <p.zabel@pengutronix.de>

> Cc: dri-devel@lists.freedesktop.org

> Cc: linux-arm-kernel@lists.infradead.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>  drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c

> index 82430ca9b9133..a1055d5055eab 100644

> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c

> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c

> @@ -797,7 +797,7 @@ static int zynqmp_dp_link_train_ce(struct zynqmp_dp *dp)

>  }

>  

>  /**

> - * zynqmp_dp_link_train - Train the link

> + * zynqmp_dp_train - Train the link


The driver has other functions related to link training that start with
the zynqmp_dp_link_train_* prefix. I'd prefer renaming this function to
zynqmp_dp_link_train(). Bonus points if the same patch could rename
zynqmp_dp_train_loop() to zynqmp_dp_link_train_loop() too :-)

>   * @dp: DisplayPort IP core structure

>   *

>   * Return: 0 if all trains are done successfully, or corresponding error code.


-- 
Regards,

Laurent Pinchart
Lee Jones June 2, 2021, 5:38 p.m. | #2
On Wed, 02 Jun 2021, Laurent Pinchart wrote:

> Hi Lee,

> 

> Thank you for the patch.

> 

> On Wed, Jun 02, 2021 at 03:32:52PM +0100, Lee Jones wrote:

> > Fixes the following W=1 kernel build warning(s):

> > 

> >  drivers/gpu/drm/xlnx/zynqmp_dp.c:806: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead

> > 

> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>

> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > Cc: David Airlie <airlied@linux.ie>

> > Cc: Daniel Vetter <daniel@ffwll.ch>

> > Cc: Michal Simek <michal.simek@xilinx.com>

> > Cc: Philipp Zabel <p.zabel@pengutronix.de>

> > Cc: dri-devel@lists.freedesktop.org

> > Cc: linux-arm-kernel@lists.infradead.org

> > Signed-off-by: Lee Jones <lee.jones@linaro.org>

> > ---

> >  drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> > 

> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c

> > index 82430ca9b9133..a1055d5055eab 100644

> > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c

> > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c

> > @@ -797,7 +797,7 @@ static int zynqmp_dp_link_train_ce(struct zynqmp_dp *dp)

> >  }

> >  

> >  /**

> > - * zynqmp_dp_link_train - Train the link

> > + * zynqmp_dp_train - Train the link

> 

> The driver has other functions related to link training that start with

> the zynqmp_dp_link_train_* prefix. I'd prefer renaming this function to

> zynqmp_dp_link_train(). Bonus points if the same patch could rename

> zynqmp_dp_train_loop() to zynqmp_dp_link_train_loop() too :-)


Doesn't have much to do with this patch though? :)

Happy to help though.  Can I fix subsequently?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 82430ca9b9133..a1055d5055eab 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -797,7 +797,7 @@  static int zynqmp_dp_link_train_ce(struct zynqmp_dp *dp)
 }
 
 /**
- * zynqmp_dp_link_train - Train the link
+ * zynqmp_dp_train - Train the link
  * @dp: DisplayPort IP core structure
  *
  * Return: 0 if all trains are done successfully, or corresponding error code.