leds: is31fl32xx: Fix missing error code in is31fl32xx_parse_dt()

Message ID 1622545743-21240-1-git-send-email-jiapeng.chong@linux.alibaba.com
State New
Headers show
Series
  • leds: is31fl32xx: Fix missing error code in is31fl32xx_parse_dt()
Related show

Commit Message

Jiapeng Chong June 1, 2021, 11:09 a.m.
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

Eliminate the follow smatch warning:

drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing
error code 'ret'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/leds/leds-is31fl32xx.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Rivshin June 3, 2021, 9:10 p.m. | #1
On Tue,  1 Jun 2021 19:09:03 +0800
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:

> The error code is missing in this code scenario, add the error code

> '-EINVAL' to the return value 'ret'.

> 

> Eliminate the follow smatch warning:

> 

> drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing

> error code 'ret'.

> 

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>

> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>


Good catch!

Acked-by: David Rivshin <drivshin@allworx.com>


You might also want to add a:

Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")


> ---

>  drivers/leds/leds-is31fl32xx.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c

> index 2180255..899ed94 100644

> --- a/drivers/leds/leds-is31fl32xx.c

> +++ b/drivers/leds/leds-is31fl32xx.c

> @@ -385,6 +385,7 @@ static int is31fl32xx_parse_dt(struct device *dev,

>  			dev_err(dev,

>  				"Node %pOF 'reg' conflicts with another LED\n",

>  				child);

> +			ret = -EINVAL;

>  			goto err;

>  		}

>
Pavel Machek July 3, 2021, 8:19 p.m. | #2
On Thu 2021-06-03 17:10:10, David Rivshin wrote:
> On Tue,  1 Jun 2021 19:09:03 +0800

> Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:

> 

> > The error code is missing in this code scenario, add the error code

> > '-EINVAL' to the return value 'ret'.

> > 

> > Eliminate the follow smatch warning:

> > 

> > drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing

> > error code 'ret'.

> > 

> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>

> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

> 

> Good catch!

> 

> Acked-by: David Rivshin <drivshin@allworx.com>

> 

> You might also want to add a:

> 

> Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")

>


Thanks, applied. I added the fixes tag, too, but I'm not sure if this
is suitable for stable.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Patch

diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c
index 2180255..899ed94 100644
--- a/drivers/leds/leds-is31fl32xx.c
+++ b/drivers/leds/leds-is31fl32xx.c
@@ -385,6 +385,7 @@  static int is31fl32xx_parse_dt(struct device *dev,
 			dev_err(dev,
 				"Node %pOF 'reg' conflicts with another LED\n",
 				child);
+			ret = -EINVAL;
 			goto err;
 		}