[3/5] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema

Message ID 20210602123416.20378-4-a-govindraju@ti.com
State New
Headers show
Series
  • [1/5] ARM: dts: am335x: align ti,pindir-d0-out-d1-in property with dt-shema
Related show

Commit Message

Aswath Govindraju June 2, 2021, 12:34 p.m.
ti,pindir-d0-out-d1-in property is expected to be of type boolean.
Therefore, fix the property accordingly.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Nishanth Menon June 7, 2021, 1:40 p.m. | #1
On 18:04-20210602, Aswath Govindraju wrote:
> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
> Therefore, fix the property accordingly.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
No need for Fixes?

Also please split up the patches per maintainer so that we are'nt
confused on who should pick what etc..

> ---
>  arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
>  arch/arm64/boot/dts/ti/k3-am654-base-board.dts     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index f4ec9ed52939..23d51b6a9cf2 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -575,7 +575,7 @@
>  
>  	#address-cells = <1>;
>  	#size-cells= <0>;
> -	ti,pindir-d0-out-d1-in = <1>;
> +	ti,pindir-d0-out-d1-in;
>  };
>  
>  &tscadc0 {
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index eddb2ffb93ca..1b947e2c2e74 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -299,7 +299,7 @@
>  	pinctrl-0 = <&main_spi0_pins_default>;
>  	#address-cells = <1>;
>  	#size-cells= <0>;
> -	ti,pindir-d0-out-d1-in = <1>;
> +	ti,pindir-d0-out-d1-in;
>  
>  	flash@0{
>  		compatible = "jedec,spi-nor";
> -- 
> 2.17.1
>
Aswath Govindraju June 7, 2021, 1:48 p.m. | #2
Hi Nishanth,

On 07/06/21 7:10 pm, Nishanth Menon wrote:
> On 18:04-20210602, Aswath Govindraju wrote:
>> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
>> Therefore, fix the property accordingly.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> No need for Fixes?
> 

Functionality wise this is not a bug as the driver only checks for the
presence of the property. This is the reason why I did not include fixes.

> Also please split up the patches per maintainer so that we are'nt
> confused on who should pick what etc..
> 

okay. Will be aware of this from next time.

Thanks,
Aswath

>> ---
>>  arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
>>  arch/arm64/boot/dts/ti/k3-am654-base-board.dts     | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> index f4ec9ed52939..23d51b6a9cf2 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> @@ -575,7 +575,7 @@
>>  
>>  	#address-cells = <1>;
>>  	#size-cells= <0>;
>> -	ti,pindir-d0-out-d1-in = <1>;
>> +	ti,pindir-d0-out-d1-in;
>>  };
>>  
>>  &tscadc0 {
>> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> index eddb2ffb93ca..1b947e2c2e74 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> @@ -299,7 +299,7 @@
>>  	pinctrl-0 = <&main_spi0_pins_default>;
>>  	#address-cells = <1>;
>>  	#size-cells= <0>;
>> -	ti,pindir-d0-out-d1-in = <1>;
>> +	ti,pindir-d0-out-d1-in;
>>  
>>  	flash@0{
>>  		compatible = "jedec,spi-nor";
>> -- 
>> 2.17.1
>>
> 
>
Nishanth Menon June 7, 2021, 8:24 p.m. | #3
On 19:18-20210607, Aswath Govindraju wrote:
> Hi Nishanth,
> 
> On 07/06/21 7:10 pm, Nishanth Menon wrote:
> > On 18:04-20210602, Aswath Govindraju wrote:
> >> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
> >> Therefore, fix the property accordingly.
> >>
> >> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> > No need for Fixes?
> > 
> 
> Functionality wise this is not a bug as the driver only checks for the
> presence of the property. This is the reason why I did not include fixes.
> 

Argument was based on device tree is considered independent of what or
what not a driver does.

> > Also please split up the patches per maintainer so that we are'nt
> > confused on who should pick what etc..
> > 
> 
> okay. Will be aware of this from next time.
> 

Actually, I have dropped this off my list. I am assuming you'd want the
bindings to be merged after the dts cleanup is done.

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
index f4ec9ed52939..23d51b6a9cf2 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
@@ -575,7 +575,7 @@ 
 
 	#address-cells = <1>;
 	#size-cells= <0>;
-	ti,pindir-d0-out-d1-in = <1>;
+	ti,pindir-d0-out-d1-in;
 };
 
 &tscadc0 {
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index eddb2ffb93ca..1b947e2c2e74 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -299,7 +299,7 @@ 
 	pinctrl-0 = <&main_spi0_pins_default>;
 	#address-cells = <1>;
 	#size-cells= <0>;
-	ti,pindir-d0-out-d1-in = <1>;
+	ti,pindir-d0-out-d1-in;
 
 	flash@0{
 		compatible = "jedec,spi-nor";