diff mbox

[Xen-devel] xen/arm: timer: Don't warn if the timer interrupts are high-level

Message ID 1425311697-21272-1-git-send-email-julien.grall@linaro.org
State Accepted
Commit d4b67cfd8433fa5c515fe9134737c1348758a222
Headers show

Commit Message

Julien Grall March 2, 2015, 3:54 p.m. UTC 
The commit 61d6a84 "xen: arm: Warn if timer interrupts are not level
triggered" added a check to ensure the timer interrupts are level.

Although, the check is only done on low-level interrupts. This will
result to a strange warning on platform using high-level ("WARNING [..]
IRQ is not level triggered").

As high-level interrupt is valid, don't warn on both high-level and
low-level interrupt.

Signed-off-by: Julien Grall <julien.grall@linaro.org>

---

The Seattle DT is using high-level interrupt. Also I haven't tried to
boot the latest Xen on it...
---
 xen/arch/arm/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index 8977cce..352e25e 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -217,7 +217,7 @@  static void check_timer_irq_cfg(unsigned int irq, const char *which)
      * The interrupt controller driver will update desc->arch.type with
      * the actual type which ended up configured in the hardware.
      */
-    if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_LOW )
+    if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_MASK )
         return;
 
     printk(XENLOG_WARNING