diff mbox series

[v4] arm64: dts: qcom: sc7180: Add DisplayPort node

Message ID 1622758940-13485-1-git-send-email-khsieh@codeaurora.org
State Superseded
Headers show
Series [v4] arm64: dts: qcom: sc7180: Add DisplayPort node | expand

Commit Message

Kuogee Hsieh June 3, 2021, 10:22 p.m. UTC
Add DP device node on sc7180.

Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
---
Changes in v2:
-- replace msm_dp with dp
-- replace dp_opp_table with opp_table

Changes in v3:
-- correct text of commit title

Changes in v4:
-- replace dp with mdss_dp
-- replace opp_table with dp_opp_table


 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi |  9 ++++
 arch/arm64/boot/dts/qcom/sc7180.dtsi         | 78 ++++++++++++++++++++++++++++
 2 files changed, 87 insertions(+)

Comments

Bjorn Andersson June 25, 2021, 4:13 p.m. UTC | #1
On Thu 03 Jun 17:22 CDT 2021, Kuogee Hsieh wrote:

> Add DP device node on sc7180.

> 

> Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>

> ---

> Changes in v2:

> -- replace msm_dp with dp

> -- replace dp_opp_table with opp_table

> 

> Changes in v3:

> -- correct text of commit title

> 

> Changes in v4:

> -- replace dp with mdss_dp

> -- replace opp_table with dp_opp_table

> 

> 

>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi |  9 ++++

>  arch/arm64/boot/dts/qcom/sc7180.dtsi         | 78 ++++++++++++++++++++++++++++

>  2 files changed, 87 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi

> index 24d293e..051fb40 100644

> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi

> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi

> @@ -786,6 +786,15 @@ hp_i2c: &i2c9 {

>  	status = "okay";

>  };

>  

> +&mdss_dp {

> +        status = "okay";

> +        pinctrl-names = "default";

> +        pinctrl-0 = <&dp_hot_plug_det>;

> +        data-lanes = <0 1>;

> +        vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>;

> +        vdda-0p9-supply = <&vdda_usb_ss_dp_core>;

> +};

> +

>  &pm6150_adc {

>  	charger-thermistor@4f {

>  		reg = <ADC5_AMUX_THM3_100K_PU>;

> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi

> index 6228ba2..c779ad3 100644

> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi

> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi

> @@ -3032,6 +3032,13 @@

>  							remote-endpoint = <&dsi0_in>;

>  						};

>  					};

> +

> +					port@2 {

> +						reg = <2>;

> +						dpu_intf0_out: endpoint {

> +							remote-endpoint = <&dp_in>;

> +						};

> +					};

>  				};

>  

>  				mdp_opp_table: mdp-opp-table {

> @@ -3148,6 +3155,77 @@

>  

>  				status = "disabled";

>  			};

> +

> +			mdss_dp: displayport-controller@ae90000 {

> +				compatible = "qcom,sc7180-dp";

> +				status = "disabled";

> +

> +				reg = <0 0x0ae90000 0 0x1400>;

> +

> +				interrupt-parent = <&mdss>;

> +				interrupts = <12>;

> +

> +				clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,

> +					 <&dispcc DISP_CC_MDSS_DP_AUX_CLK>,

> +					 <&dispcc DISP_CC_MDSS_DP_LINK_CLK>,

> +					 <&dispcc DISP_CC_MDSS_DP_LINK_INTF_CLK>,

> +					 <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>;

> +				clock-names = "core_iface", "core_aux", "ctrl_link",

> +					      "ctrl_link_iface", "stream_pixel";

> +				#clock-cells = <1>;

> +				assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>,

> +						  <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;

> +				assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>;

> +				phys = <&dp_phy>;

> +				phy-names = "dp";

> +

> +				operating-points-v2 = <&dp_opp_table>;

> +				power-domains = <&rpmhpd SC7180_CX>;

> +

> +				#sound-dai-cells = <0>;

> +

> +				ports {

> +					#address-cells = <1>;

> +					#size-cells = <0>;

> +					port@0 {

> +						reg = <0>;

> +						dp_in: endpoint {

> +							remote-endpoint = <&dpu_intf0_out>;

> +						};

> +					};

> +

> +					port@1 {

> +						reg = <1>;

> +						dp_out: endpoint { };

> +					};

> +				};

> +

> +				dp_opp_table: dp-opp-table {


I forgot that our discussion about the node name here was on the
previous revision, _this_ is the patch I will drop the "dp-" from and
apply.

And as I've looked at this quite a bit now:

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Thanks for following up on the other feedback!

Regards,
Bjorn

> +					compatible = "operating-points-v2";

> +

> +					opp-160000000 {

> +						opp-hz = /bits/ 64 <160000000>;

> +						required-opps = <&rpmhpd_opp_low_svs>;

> +					};

> +

> +					opp-270000000 {

> +						opp-hz = /bits/ 64 <270000000>;

> +						required-opps = <&rpmhpd_opp_svs>;

> +					};

> +

> +					opp-540000000 {

> +						opp-hz = /bits/ 64 <540000000>;

> +						required-opps = <&rpmhpd_opp_svs_l1>;

> +					};

> +

> +					opp-810000000 {

> +						opp-hz = /bits/ 64 <810000000>;

> +						required-opps = <&rpmhpd_opp_nom>;

> +					};

> +				};

> +			};

> +

> +

>  		};

>  

>  		dispcc: clock-controller@af00000 {

> -- 

> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,

> a Linux Foundation Collaborative Project

>
Stephen Boyd June 30, 2021, 5:51 p.m. UTC | #2
Quoting Bjorn Andersson (2021-06-25 09:13:45)
> On Thu 03 Jun 17:22 CDT 2021, Kuogee Hsieh wrote:

> > +                                             dp_out: endpoint { };

> > +                                     };

> > +                             };

> > +

> > +                             dp_opp_table: dp-opp-table {

>

> I forgot that our discussion about the node name here was on the

> previous revision, _this_ is the patch I will drop the "dp-" from and

> apply.

>

> And as I've looked at this quite a bit now:

>

> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

>


With that node name fixed

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 24d293e..051fb40 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -786,6 +786,15 @@  hp_i2c: &i2c9 {
 	status = "okay";
 };
 
+&mdss_dp {
+        status = "okay";
+        pinctrl-names = "default";
+        pinctrl-0 = <&dp_hot_plug_det>;
+        data-lanes = <0 1>;
+        vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>;
+        vdda-0p9-supply = <&vdda_usb_ss_dp_core>;
+};
+
 &pm6150_adc {
 	charger-thermistor@4f {
 		reg = <ADC5_AMUX_THM3_100K_PU>;
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 6228ba2..c779ad3 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3032,6 +3032,13 @@ 
 							remote-endpoint = <&dsi0_in>;
 						};
 					};
+
+					port@2 {
+						reg = <2>;
+						dpu_intf0_out: endpoint {
+							remote-endpoint = <&dp_in>;
+						};
+					};
 				};
 
 				mdp_opp_table: mdp-opp-table {
@@ -3148,6 +3155,77 @@ 
 
 				status = "disabled";
 			};
+
+			mdss_dp: displayport-controller@ae90000 {
+				compatible = "qcom,sc7180-dp";
+				status = "disabled";
+
+				reg = <0 0x0ae90000 0 0x1400>;
+
+				interrupt-parent = <&mdss>;
+				interrupts = <12>;
+
+				clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
+					 <&dispcc DISP_CC_MDSS_DP_AUX_CLK>,
+					 <&dispcc DISP_CC_MDSS_DP_LINK_CLK>,
+					 <&dispcc DISP_CC_MDSS_DP_LINK_INTF_CLK>,
+					 <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>;
+				clock-names = "core_iface", "core_aux", "ctrl_link",
+					      "ctrl_link_iface", "stream_pixel";
+				#clock-cells = <1>;
+				assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>,
+						  <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;
+				assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>;
+				phys = <&dp_phy>;
+				phy-names = "dp";
+
+				operating-points-v2 = <&dp_opp_table>;
+				power-domains = <&rpmhpd SC7180_CX>;
+
+				#sound-dai-cells = <0>;
+
+				ports {
+					#address-cells = <1>;
+					#size-cells = <0>;
+					port@0 {
+						reg = <0>;
+						dp_in: endpoint {
+							remote-endpoint = <&dpu_intf0_out>;
+						};
+					};
+
+					port@1 {
+						reg = <1>;
+						dp_out: endpoint { };
+					};
+				};
+
+				dp_opp_table: dp-opp-table {
+					compatible = "operating-points-v2";
+
+					opp-160000000 {
+						opp-hz = /bits/ 64 <160000000>;
+						required-opps = <&rpmhpd_opp_low_svs>;
+					};
+
+					opp-270000000 {
+						opp-hz = /bits/ 64 <270000000>;
+						required-opps = <&rpmhpd_opp_svs>;
+					};
+
+					opp-540000000 {
+						opp-hz = /bits/ 64 <540000000>;
+						required-opps = <&rpmhpd_opp_svs_l1>;
+					};
+
+					opp-810000000 {
+						opp-hz = /bits/ 64 <810000000>;
+						required-opps = <&rpmhpd_opp_nom>;
+					};
+				};
+			};
+
+
 		};
 
 		dispcc: clock-controller@af00000 {