[v5,01/13] ata: ahci-pci: Use scsi_ops to initialize ops

Message ID 162279980314.518877.13836619565702125311.stgit@localhost
State New
Headers show
Series
  • arm64: synquacer: Add SynQuacer/DeveloperBox support
Related show

Commit Message

Masami Hiramatsu June 4, 2021, 9:43 a.m.
Without this fix, scsi-scan will cause a synchronous abort
when accessing ops->scan.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>

Reviewed-by: Simon Glass <sjg@chromium.org>

---
 drivers/ata/ahci-pci.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Tom Rini July 6, 2021, 10:50 p.m. | #1
On Fri, Jun 04, 2021 at 06:43:23PM +0900, Masami Hiramatsu wrote:

> Without this fix, scsi-scan will cause a synchronous abort

> when accessing ops->scan.

> 

> Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>

> Reviewed-by: Simon Glass <sjg@chromium.org>


For the entire series, applied to u-boot/master, thanks!

-- 
Tom
Masami Hiramatsu July 7, 2021, 10:47 p.m. | #2
Hi Tom,

2021年7月7日(水) 7:50 Tom Rini <trini@konsulko.com>:
>

> On Fri, Jun 04, 2021 at 06:43:23PM +0900, Masami Hiramatsu wrote:

>

> > Without this fix, scsi-scan will cause a synchronous abort

> > when accessing ops->scan.

> >

> > Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>

> > Reviewed-by: Simon Glass <sjg@chromium.org>

>

> For the entire series, applied to u-boot/master, thanks!


Thank you so much!

I have some updates, so I'll send it.

Regards,

-- 
Masami Hiramatsu

Patch

diff --git a/drivers/ata/ahci-pci.c b/drivers/ata/ahci-pci.c
index 11ec98b56f..b1d231e0f9 100644
--- a/drivers/ata/ahci-pci.c
+++ b/drivers/ata/ahci-pci.c
@@ -5,6 +5,7 @@ 
 
 #include <common.h>
 #include <ahci.h>
+#include <scsi.h>
 #include <dm.h>
 #include <pci.h>
 
@@ -28,6 +29,7 @@  static const struct udevice_id ahci_pci_ids[] = {
 U_BOOT_DRIVER(ahci_pci) = {
 	.name	= "ahci_pci",
 	.id	= UCLASS_AHCI,
+	.ops	= &scsi_ops,
 	.of_match = ahci_pci_ids,
 	.bind	= ahci_pci_bind,
 	.probe = ahci_pci_probe,