diff mbox

validation: pktio: disable arp on virtual interfaces

Message ID 1425636054-10784-1-git-send-email-maxim.uvarov@linaro.org
State Accepted
Commit 66fe09dcf7bc55370781c42459ec84abfb56b195
Headers show

Commit Message

Maxim Uvarov March 6, 2015, 10 a.m. UTC
Virtual interfaces for linux-generic tests does not have
arp addresses. Arp discovery has to be turned off.

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
---
 test/validation/odp_pktio_run | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stuart Haslam March 6, 2015, 10:37 a.m. UTC | #1
On Fri, Mar 06, 2015 at 01:00:54PM +0300, Maxim Uvarov wrote:
> Virtual interfaces for linux-generic tests does not have
> arp addresses. Arp discovery has to be turned off.
> 

Why? Presumably you're making this change because without it you had a
problem, what was it?

--
Stuart.
Maxim Uvarov March 6, 2015, 10:49 a.m. UTC | #2
On 03/06/15 13:37, Stuart Haslam wrote:
> On Fri, Mar 06, 2015 at 01:00:54PM +0300, Maxim Uvarov wrote:
>> Virtual interfaces for linux-generic tests does not have
>> arp addresses. Arp discovery has to be turned off.
>>
> Why? Presumably you're making this change because without it you had a
> problem, what was it?
>
> --
> Stuart.
I saw interesting problem where I was unable to recieve any packets on 
interface. I did test to run odp_generator which
creates IP packet and sends to other virtual interface. But actually IP 
packet can not be delivered until you define arp
table. Because I want to reuse that environment for pktio performance 
tests I need to disable arp or set fake arp addresses.

Maxim.
Maxim Uvarov March 12, 2015, 9:23 a.m. UTC | #3
On 03/06/15 13:37, Stuart Haslam wrote:
> On Fri, Mar 06, 2015 at 01:00:54PM +0300, Maxim Uvarov wrote:
>> Virtual interfaces for linux-generic tests does not have
>> arp addresses. Arp discovery has to be turned off.
>>
> Why? Presumably you're making this change because without it you had a
> problem, what was it?
>
> --
> Stuart.
I think we need this to go in, right?

Maxim.
Stuart Haslam March 12, 2015, 11:01 a.m. UTC | #4
On Thu, Mar 12, 2015 at 12:23:28PM +0300, Maxim Uvarov wrote:
> On 03/06/15 13:37, Stuart Haslam wrote:
> >On Fri, Mar 06, 2015 at 01:00:54PM +0300, Maxim Uvarov wrote:
> >>Virtual interfaces for linux-generic tests does not have
> >>arp addresses. Arp discovery has to be turned off.
> >>
> >Why? Presumably you're making this change because without it you had a
> >problem, what was it?
> >
> >--
> >Stuart.
> I think we need this to go in, right?
> 
> Maxim.

OK, but please make a change in the commit log;

"does not have arp addresses" -> "do not have an IP address assigned"

With that;

Reviewed-by: Stuart Haslam <stuart.haslam@linaro.org>
diff mbox

Patch

diff --git a/test/validation/odp_pktio_run b/test/validation/odp_pktio_run
index 08288e6..c81eb7d 100755
--- a/test/validation/odp_pktio_run
+++ b/test/validation/odp_pktio_run
@@ -58,6 +58,8 @@  setup_env1()
 	fi
 	ip link set $IF0 up
 	ip link set $IF1 up
+	ifconfig $IF0 -arp
+	ifconfig $IF1 -arp
 
 	# network needs a little time to come up
 	sleep 1