[1/1] mtd: mtdoops: remove unnecessary oom message

Message ID 20210610021201.15076-1-thunder.leizhen@huawei.com
State New
Headers show
Series
  • [1/1] mtd: mtdoops: remove unnecessary oom message
Related show

Commit Message

Zhen Lei June 10, 2021, 2:12 a.m.
Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

---
 drivers/mtd/mtdoops.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
2.26.0.106.g9fadedd



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Comments

Miquel Raynal June 11, 2021, 6:59 p.m. | #1
On Thu, 2021-06-10 at 02:12:01 UTC, Zhen Lei wrote:
> Fixes scripts/checkpatch.pl warning:

> WARNING: Possible unnecessary 'out of memory' message

> 

> Remove it can help us save a bit of memory.

> 

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>


Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Patch

diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c
index 862c4a8892346bc..227df24387df5e2 100644
--- a/drivers/mtd/mtdoops.c
+++ b/drivers/mtd/mtdoops.c
@@ -401,10 +401,8 @@  static int __init mtdoops_init(void)
 		cxt->mtd_index = mtd_index;
 
 	cxt->oops_buf = vmalloc(record_size);
-	if (!cxt->oops_buf) {
-		printk(KERN_ERR "mtdoops: failed to allocate buffer workspace\n");
+	if (!cxt->oops_buf)
 		return -ENOMEM;
-	}
 	memset(cxt->oops_buf, 0xff, record_size);
 	cxt->oops_buf_busy = 0;