From patchwork Thu Jun 10 03:00:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 457806 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp5995632jae; Wed, 9 Jun 2021 20:03:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznx4N1hBtNawWT1G5hWE7oUZMweLhRWjWXmHZsG2MF1hpL2IsYxrX8xfOqfqAsGC9EYgfV X-Received: by 2002:a17:906:bcd5:: with SMTP id lw21mr2467976ejb.346.1623294181397; Wed, 09 Jun 2021 20:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623294181; cv=none; d=google.com; s=arc-20160816; b=NrmGBDUKVINEgMsma8m9xfd/PwhAo2vizqS+aOPrCv1R+NdcvaN+o5XHfN5CoHo4oD oQr1rBqT+1B8Umy1Q3CQ/xqSaPmQNs7HPNs0JdqqcFNvGLkGUGPJd6xF2WClvd5H4IDG CEgAzXhM7jJLDaAHlgQTpBEKQvTNiHPmF0T25Q0HvYotqEp6TQGDW4YSaMTWmchnj7db iJ9wkBZmS54Yu3EJ+PEiC+zlRsQMfeIoMk/v/qJ3o/mU0uLcwUGfZyR02/SkCrVMx9BQ 7yZaTJ8Jqt8Bwjgjb+lN+WFe2CeKdF4RTZJdctEShEoyeFMp8BFMCUTndgkBe2v6+VG3 hUZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=/8ibD6cQOjhaJXZZr2PzLWT0t0cHU41OsDeIEIeHwvk=; b=qtylWGz0CFML+x2foPz/h7avZCbhIqDHq/auA2QT4WU81kj1JBa3C3OBwDbOstVI1/ 7u8zWStVmxKkhtoITgfu4Omhy5mpcPkRlvBCLsja1maBZsq788YXDKmLPPQA7zoSVYmH IJxINH0wwMLkipvNUhoxMb2rZV1RT15kvJgizcTPpKslwuOnrJjL7Pl/z9+Yeail43ii mPsxi6XQ7hfyyy3GXPlm7bO1wVck0IB5Qsmt8I71DDFpsfeuTMfB+qNFHEV6nsjI3x/9 Wk99TIK9J3LtSCpgaSWZPBg1XAR3aNcWgv7NALkvM5edaAWthJj/TheBxhJB/uhjz0XR PZrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=K4auMbfs; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z21si1257438ejf.623.2021.06.09.20.03.01; Wed, 09 Jun 2021 20:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=K4auMbfs; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbhFJDDu (ORCPT + 4 others); Wed, 9 Jun 2021 23:03:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbhFJDDt (ORCPT ); Wed, 9 Jun 2021 23:03:49 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EABEC061574 for ; Wed, 9 Jun 2021 20:01:39 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id pi6-20020a17090b1e46b029015cec51d7cdso2895692pjb.5 for ; Wed, 09 Jun 2021 20:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/8ibD6cQOjhaJXZZr2PzLWT0t0cHU41OsDeIEIeHwvk=; b=K4auMbfs7bES5EGJD02j5sl9z3PZ0Ov5AeACVWNt7t+M9Z+Te+BI/oSrfnGDeA63+v EwVaKsVsKcOl9uOOqUJtquiW9nA0PhECGxIaerfC+uyLFzZjmbvrkWVAJME3jloSJCZt Qal1MqXrV1wRpRKZ65YdYXDiQOSDDJuEYwFJfLAvij4asR/teM/nIUV8vW/yWq8jqI0G SVbrZfDRXYLcDbZxHvRoQUfuIbB+2DYXxmfd0osSFJwp6TTRa8bJyGxsLbm1ZsysrzR4 QvFb7w1wwTi3H6a1oKsmf2p7Cy+ejrfxtUqOMkLFUVesoYvciNezwZfBFrecWwjLGwac IFCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=/8ibD6cQOjhaJXZZr2PzLWT0t0cHU41OsDeIEIeHwvk=; b=MdXKD4lB5tEaUCx4JWzoLhEJ0dMSiH9yxmWbR2DptQWpErX2D/CwoGl7poYeIOVv6W LXVSAFpMUH6uj+N7KQv+RvPiHF6ovvkyaUtUiUy/vSNEBLZ1IquMRI3Yer6o1hwBDPk5 kGeDBfn8JRz1B/7rOr6s8GKVByEA9EMAigTGlJdz8Uvo2dqVkRqou5womsoYBYyDZA/O qwHUvgCcTJ32MByRVgYFLn7hbBehnFDb4rlRgag4wWlWZhazWQaV6+0ndt6ksmPf5hHd b0VNLrif2ogZnD1PWZ6o7yR/lMzBvq+iPXbYKuuLAywCR510cjkYhdeGuVatO7Xnq6Bi pc0g== X-Gm-Message-State: AOAM5324ljBqFZ0fYfy5ITa4sBxE5lFjzhcda4Be0eaaV+eCstYVNHWi fKSU2YMnRSpQJ21DQvYRZVI= X-Received: by 2002:a17:90a:ea86:: with SMTP id h6mr979071pjz.71.1623294096376; Wed, 09 Jun 2021 20:01:36 -0700 (PDT) Received: from localhost.localdomain ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id s7sm60358pfh.57.2021.06.09.20.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 20:01:35 -0700 (PDT) Sender: "joel.stan@gmail.com" From: Joel Stanley To: Fabio Estevam , Peter Chen , Arnd Bergmann , Felipe Balbi Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] usb: gadget: fsl: Re-enable driver for ARM SoCs Date: Thu, 10 Jun 2021 12:30:35 +0930 Message-Id: <20210610030035.76864-1-joel@jms.id.au> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") dropped the ARCH_MXC dependency from USB_FSL_USB2, leaving it depending solely on FSL_SOC. FSL_SOC is powerpc only; it was briefly available on ARM in 2014 with commit cfd074ad8600 ("ARM: imx: temporarily remove CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be enabled on ARM platforms. This appears to be a mistake as arm64's ARCH_LAERSCAPE and arm32 SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs: arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the ARM platforms, and with COMPILE_TEST. Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") Signed-off-by: Joel Stanley --- drivers/usb/gadget/udc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig index 8c614bb86c66..b32cea2fb99f 100644 --- a/drivers/usb/gadget/udc/Kconfig +++ b/drivers/usb/gadget/udc/Kconfig @@ -90,7 +90,7 @@ config USB_BCM63XX_UDC config USB_FSL_USB2 tristate "Freescale Highspeed USB DR Peripheral Controller" - depends on FSL_SOC + depends on FSL_SOC || ARCH_LAYERSACPE || SOC_LS1021A || COMPILE_TEST help Some of Freescale PowerPC and i.MX processors have a High Speed Dual-Role(DR) USB controller, which supports device mode.