From patchwork Thu Jun 10 03:49:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 457807 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp6019462jae; Wed, 9 Jun 2021 20:51:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyx2P9y4EZrdqWonI+CSPmswnP/chJO2LB3D5/1S8s26c+hZy7WTGhGAfE0wtN7zOIJ98TL X-Received: by 2002:a17:906:9d05:: with SMTP id fn5mr2529739ejc.133.1623297073257; Wed, 09 Jun 2021 20:51:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623297073; cv=none; d=google.com; s=arc-20160816; b=ocEdlNfE0gehRxfnry+RJ+ncZpugz7PIWJFRRDS5L8TfqflMvw5mriNaWE0y2mCsd+ KfKscEFPxZ8xj/qtj6f7UkQ9EV9pMK7z8xEEdxYCXpiegOODHQ27Jxc3P+1AVz+EuaSj 8b6tOBCVu1E658Ve69P3i6tgML7q0yqiAFFEblR/KxI6lAurH7YI/2ElLpZL8u3+C41u RMMWDcgZ8RqLvGiplVykscn4hb3U2KP+vv9sxKr0viiaIvamYGMLiVRSrPazJGPqYwmW ymYjP94YM8rIcWgBjnuNyGX13hk+3Id97fMO4SnnAMj3nP7DS/m9RmOGl1lgQ3DoXh75 AVyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=pwLscPt/B/b/5SFEs+HEyMeL+d3/cTsy8u9p+tu3dIo=; b=Jk3cHzEebSV9SDA399BYAsBeTsmdnVV6m5C7aeeNc3Hr/YRtfPSL34hAvUppYTwHgs YemoNdFtUoStTXd4k419WuQfgE0gNXJdbgJVTKaW7my1r38EpvEzaRoYBm0PHNK3b0I0 +6doKw4ayTjTKZ9Ckh+4vHOGkxcu6/+TyfcTpAxEY9Qfl5OX52ZUe48nqFSeGtxDXJDM UHeP1UINiC65LzOzjKK3i20++AM3cX1Wi8kAHz4bZuTT6Z+MlcceFGv9PghlhBF/Atss A7xzmOeTIbPiZoukooDm0NHbtSjbOzz4mEWRIzlUZsQypTvnY5GEb7ogIzeB/lTgS8sG Slgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qv8v8cqG; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dg2si1192506edb.424.2021.06.09.20.51.13; Wed, 09 Jun 2021 20:51:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qv8v8cqG; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbhFJDwG (ORCPT + 4 others); Wed, 9 Jun 2021 23:52:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbhFJDwF (ORCPT ); Wed, 9 Jun 2021 23:52:05 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AF0AC061574 for ; Wed, 9 Jun 2021 20:50:09 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id fy24-20020a17090b0218b029016c5a59021fso2935796pjb.0 for ; Wed, 09 Jun 2021 20:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pwLscPt/B/b/5SFEs+HEyMeL+d3/cTsy8u9p+tu3dIo=; b=qv8v8cqG/Ai5hMpH29a1Q5T6WTaZ4NIrnjR7FhyNFtOKgcW9hmlCU70zYVrhvvDLqY UY33gGZykUoKQSAN9jQCoq/iedqBijDGaSG035hsMTsxxl2VjuFMFBycKVk4I8QL3dfS 3ro3lQ0sgaBszICT3LUjgW505aUGgNdBPhJR1N8FyGvY4IhC8ir8pbLZX7y8JOXGxnwZ RNIWKR0wV3CaJBWXRzNxUUc26pgmlBhEJ8r1dEEjOxE56liOa4YtS1iuOnA9XdcXcHcm mYQSg17HTK0Xrh4dTpVrfJtw7GuzTm341QJDbqS5a44hgXqMoe0rVoeo4WJrpQhANm2b qSSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=pwLscPt/B/b/5SFEs+HEyMeL+d3/cTsy8u9p+tu3dIo=; b=Yf96/KeEsw4f6CF9NplIBF/vkQ3bCPbwDgdKT+uoMbL6PAO91O4PUAXiN/+CzjUIgi ODDleraD1+pgLJiTY3tojd2F5KEEaWeP5x8AF5o7VcpYOHoTaTZ0xGXJraz2gNIuzWlu e+vEYWRABrAY5jmXiCjYguhjOBjW7UeWVWZEI9RhSilkT6/PfETS/ixskbn1n9GzCUQy Et15rtaFYOwddQbJuSNKntfvAcEZ2E/wSC7/Rhi0prqGdAnp03+15Vqhei3X/+Lk2vCL fL4LqLE2KrpIqgVfXEp1iAfl0Fj6WeoFB/fu2VYlYUI1Jh0YKo2wM3+HslZlXx63AgUf meww== X-Gm-Message-State: AOAM530bMFA+MR1zGyX24xDfWzV5koKmn/qnKDy/vvDGWcjIcbRqXOhM MN+dyuOagGh5NQ2e2Lm0Kog= X-Received: by 2002:a17:90a:6289:: with SMTP id d9mr1157140pjj.84.1623297009088; Wed, 09 Jun 2021 20:50:09 -0700 (PDT) Received: from localhost.localdomain ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id j13sm1062652pgp.29.2021.06.09.20.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 20:50:08 -0700 (PDT) Sender: "joel.stan@gmail.com" From: Joel Stanley To: Fabio Estevam , Peter Chen , Arnd Bergmann , Felipe Balbi Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs Date: Thu, 10 Jun 2021 13:19:57 +0930 Message-Id: <20210610034957.93376-1-joel@jms.id.au> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") dropped the ARCH_MXC dependency from USB_FSL_USB2, leaving it depending solely on FSL_SOC. FSL_SOC is powerpc only; it was briefly available on ARM in 2014 but was removed by commit cfd074ad8600 ("ARM: imx: temporarily remove CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be enabled on ARM platforms. This appears to be a mistake as arm64's ARCH_LAYERSCAPE and arm32 SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs: arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the ARM platforms, and with COMPILE_TEST. Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") Signed-off-by: Joel Stanley --- v2: Fix spelling of ARCH_LAYERSCAPE --- drivers/usb/gadget/udc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig index 8c614bb86c66..7348acbdc560 100644 --- a/drivers/usb/gadget/udc/Kconfig +++ b/drivers/usb/gadget/udc/Kconfig @@ -90,7 +90,7 @@ config USB_BCM63XX_UDC config USB_FSL_USB2 tristate "Freescale Highspeed USB DR Peripheral Controller" - depends on FSL_SOC + depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST help Some of Freescale PowerPC and i.MX processors have a High Speed Dual-Role(DR) USB controller, which supports device mode.