| Message ID | 20210610080243.4097179-1-yangyingliang@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] fjes: check return value after calling platform_get_resource() | expand |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 10 Jun 2021 16:02:43 +0800 you wrote: > It will cause null-ptr-deref if platform_get_resource() returns NULL, > we need check the return value. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/net/fjes/fjes_main.c | 4 ++++ > 1 file changed, 4 insertions(+) Here is the summary with links: - [net-next] fjes: check return value after calling platform_get_resource() https://git.kernel.org/netdev/net-next/c/f18c11812c94 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index d098b1fcf006..185c8a398681 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -1254,6 +1254,10 @@ static int fjes_probe(struct platform_device *plat_dev) adapter->interrupt_watch_enable = false; res = platform_get_resource(plat_dev, IORESOURCE_MEM, 0); + if (!res) { + err = -EINVAL; + goto err_free_control_wq; + } hw->hw_res.start = res->start; hw->hw_res.size = resource_size(res); hw->hw_res.irq = platform_get_irq(plat_dev, 0);
It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/fjes/fjes_main.c | 4 ++++ 1 file changed, 4 insertions(+)