| Message ID | 20210613231647.511805-1-linus.walleij@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | leds: lgm: Fix up includes | expand |
On Mon 2021-06-14 01:16:47, Linus Walleij wrote: > This driver is including the legacy GPIO header <linux/gpio.h> > but the only thing it is using from that header is the wrong > define for GPIOF_DIR_OUT. > > Fix it up by using GPIO_LINE_DIRECTION_OUT and including the > correct consumer and driver headers. > > Cc: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Thanks, applied. Pavel -- http://www.livejournal.com/~pavelmachek
diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lgm-sso.c index 6a63846d10b5..4c70f7d022ac 100644 --- a/drivers/leds/blink/leds-lgm-sso.c +++ b/drivers/leds/blink/leds-lgm-sso.c @@ -7,7 +7,8 @@ #include <linux/bitfield.h> #include <linux/clk.h> -#include <linux/gpio.h> +#include <linux/gpio/consumer.h> +#include <linux/gpio/driver.h> #include <linux/init.h> #include <linux/kernel.h> #include <linux/leds.h> @@ -423,7 +424,7 @@ static void sso_gpio_free(struct gpio_chip *chip, unsigned int offset) static int sso_gpio_get_dir(struct gpio_chip *chip, unsigned int offset) { - return GPIOF_DIR_OUT; + return GPIO_LINE_DIRECTION_OUT; } static int
This driver is including the legacy GPIO header <linux/gpio.h> but the only thing it is using from that header is the wrong define for GPIOF_DIR_OUT. Fix it up by using GPIO_LINE_DIRECTION_OUT and including the correct consumer and driver headers. Cc: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/leds/blink/leds-lgm-sso.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.31.1