| Message ID | 20210613220326.831040-1-pbrobinson@gmail.com |
|---|---|
| State | Accepted |
| Commit | 6d49b3a0f351925b5ea5047166c112b7590b918a |
| Headers | show |
| Series | gpio: pca953x: Add support for the On Semi pca9655 | expand |
On Mon, Jun 14, 2021 at 1:05 AM Peter Robinson <pbrobinson@gmail.com> wrote: > > The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO > expander, with 16 GPIOs and interrupt functionality. I don't remember the context... > { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), }, > { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), }, > + { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), }, ...but the first space (before 16) seems not necessary and the idea as far as I can see from here is to have those columns to be indented nicely. > { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), }, > { } -- With Best Regards, Andy Shevchenko
On Mon, Jun 14, 2021 at 10:10 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Mon, Jun 14, 2021 at 1:05 AM Peter Robinson <pbrobinson@gmail.com> wrote: > > > > The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO > > expander, with 16 GPIOs and interrupt functionality. > > I don't remember the context... > > > { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), }, > > { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), }, > > + { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), }, > > ...but the first space (before 16) seems not necessary and the idea as > far as I can see from here is to have those columns to be indented > nicely. > > > { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), }, > > { } > > -- > With Best Regards, > Andy Shevchenko I applied the patch and fixed the indentation problem in my tree. Thanks! Bart
On Wed, Jun 16, 2021 at 8:28 PM Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote: > > On Mon, Jun 14, 2021 at 10:10 AM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > > > On Mon, Jun 14, 2021 at 1:05 AM Peter Robinson <pbrobinson@gmail.com> wrote: > > > > > > The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO > > > expander, with 16 GPIOs and interrupt functionality. > > > > I don't remember the context... > > > > > { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), }, > > > { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), }, > > > + { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), }, > > > > ...but the first space (before 16) seems not necessary and the idea as > > far as I can see from here is to have those columns to be indented > > nicely. > > > > > { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), }, > > > { } > > > > -- > > With Best Regards, > > Andy Shevchenko > > I applied the patch and fixed the indentation problem in my tree. Thanks! Awesome, thanks!
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index c91d05651596..348040247b0b 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -1241,6 +1241,7 @@ static const struct of_device_id pca953x_dt_ids[] = { { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), }, { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), }, + { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), }, { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), }, { }
The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO expander, with 16 GPIOs and interrupt functionality. Signed-off-by: Peter Robinson <pbrobinson@gmail.com> --- drivers/gpio/gpio-pca953x.c | 1 + 1 file changed, 1 insertion(+)