| Message ID | 20210612145122.9354-1-paskripkin@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | net: caif: fix memory leak in ldisc_open | expand |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sat, 12 Jun 2021 17:51:22 +0300 you wrote: > Syzbot reported memory leak in tty_init_dev(). > The problem was in unputted tty in ldisc_open() > > static int ldisc_open(struct tty_struct *tty) > { > ... > ser->tty = tty_kref_get(tty); > ... > result = register_netdevice(dev); > if (result) { > rtnl_unlock(); > free_netdev(dev); > return -ENODEV; > } > ... > } > > [...] Here is the summary with links: - net: caif: fix memory leak in ldisc_open https://git.kernel.org/netdev/net/c/58af3d3d54e8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c index d17482395a4d..4ffbfd534f18 100644 --- a/drivers/net/caif/caif_serial.c +++ b/drivers/net/caif/caif_serial.c @@ -350,6 +350,7 @@ static int ldisc_open(struct tty_struct *tty) rtnl_lock(); result = register_netdevice(dev); if (result) { + tty_kref_put(tty); rtnl_unlock(); free_netdev(dev); return -ENODEV;
Syzbot reported memory leak in tty_init_dev(). The problem was in unputted tty in ldisc_open() static int ldisc_open(struct tty_struct *tty) { ... ser->tty = tty_kref_get(tty); ... result = register_netdevice(dev); if (result) { rtnl_unlock(); free_netdev(dev); return -ENODEV; } ... } Ser pointer is netdev private_data, so after free_netdev() this pointer goes away with unputted tty reference. So, fix it by adding tty_kref_put() before freeing netdev. Reported-and-tested-by: syzbot+f303e045423e617d2cad@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> --- drivers/net/caif/caif_serial.c | 1 + 1 file changed, 1 insertion(+)