diff mbox series

[v3,1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.

Message ID 1623690937-52389-2-git-send-email-zhouyanjie@wanyeetech.com
State New
Headers show
Series [v3,1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs. | expand

Commit Message

Zhou Yanjie June 14, 2021, 5:15 p.m. UTC 
Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,
the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.

Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
---

Notes:
    v1->v2:
    No change.
    
    v2->v3:
    Add "ingenic,mac.yaml" for Ingenic SoCs.

 .../devicetree/bindings/net/ingenic,mac.yaml       | 76 ++++++++++++++++++++++
 .../devicetree/bindings/net/snps,dwmac.yaml        | 15 +++++
 2 files changed, 91 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/ingenic,mac.yaml

Comments

Andrew Lunn June 14, 2021, 5:36 p.m. UTC | #1 
On Tue, Jun 15, 2021 at 01:15:36AM +0800, 周琰杰 (Zhou Yanjie) wrote:
> Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,
> the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.
> 
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Rob Herring June 15, 2021, 2:04 p.m. UTC | #2 
On Tue, 15 Jun 2021 01:15:36 +0800, 周琰杰 (Zhou Yanjie) wrote:
> Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,

> the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.

> 

> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>

> ---

> 

> Notes:

>     v1->v2:

>     No change.

> 

>     v2->v3:

>     Add "ingenic,mac.yaml" for Ingenic SoCs.

> 

>  .../devicetree/bindings/net/ingenic,mac.yaml       | 76 ++++++++++++++++++++++

>  .../devicetree/bindings/net/snps,dwmac.yaml        | 15 +++++

>  2 files changed, 91 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/net/ingenic,mac.yaml

> 


My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.example.dt.yaml: ethernet@134b0000: compatible: ['ingenic,x1000-mac', 'snps,dwmac'] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.example.dt.yaml: ethernet@134b0000: compatible: Additional items are not allowed ('snps,dwmac' was unexpected)
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.example.dt.yaml: ethernet@134b0000: 'phy-mode' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/snps,dwmac.yaml
\ndoc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1491797

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Rob Herring June 15, 2021, 11:05 p.m. UTC | #3 
On Mon, Jun 14, 2021 at 11:18 AM 周琰杰 (Zhou Yanjie)
<zhouyanjie@wanyeetech.com> wrote:
>
> Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,
> the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.
>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> ---
>
> Notes:
>     v1->v2:
>     No change.
>
>     v2->v3:
>     Add "ingenic,mac.yaml" for Ingenic SoCs.
>
>  .../devicetree/bindings/net/ingenic,mac.yaml       | 76 ++++++++++++++++++++++
>  .../devicetree/bindings/net/snps,dwmac.yaml        | 15 +++++
>  2 files changed, 91 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/ingenic,mac.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/ingenic,mac.yaml b/Documentation/devicetree/bindings/net/ingenic,mac.yaml
> new file mode 100644
> index 00000000..5fe2e81
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/ingenic,mac.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/ingenic,mac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bindings for MAC in Ingenic SoCs
> +
> +maintainers:
> +  - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> +
> +description:
> +  The Ethernet Media Access Controller in Ingenic SoCs.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ingenic,jz4775-mac
> +      - ingenic,x1000-mac
> +      - ingenic,x1600-mac
> +      - ingenic,x1830-mac
> +      - ingenic,x2000-mac
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-names:
> +    const: macirq
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: stmmaceth
> +
> +  mode-reg:
> +    description: An extra syscon register that control ethernet interface and timing delay

Needs a vendor prefix and type.

> +
> +  rx-clk-delay-ps:
> +    description: RGMII receive clock delay defined in pico seconds
> +
> +  tx-clk-delay-ps:
> +    description: RGMII transmit clock delay defined in pico seconds
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - clocks
> +  - clock-names
> +  - mode-reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/x1000-cgu.h>
> +
> +    mac: ethernet@134b0000 {
> +        compatible = "ingenic,x1000-mac", "snps,dwmac";

Doesn't match the schema.

> +        reg = <0x134b0000 0x2000>;
> +
> +        interrupt-parent = <&intc>;
> +        interrupts = <55>;
> +        interrupt-names = "macirq";
> +
> +        clocks = <&cgu X1000_CLK_MAC>;
> +        clock-names = "stmmaceth";
> +
> +        mode-reg = <&mac_phy_ctrl>;
> +    };
> +...
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2edd8be..9c0ce92 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -56,6 +56,11 @@ properties:
>          - amlogic,meson8m2-dwmac
>          - amlogic,meson-gxbb-dwmac
>          - amlogic,meson-axg-dwmac
> +        - ingenic,jz4775-mac
> +        - ingenic,x1000-mac
> +        - ingenic,x1600-mac
> +        - ingenic,x1830-mac
> +        - ingenic,x2000-mac
>          - rockchip,px30-gmac
>          - rockchip,rk3128-gmac
>          - rockchip,rk3228-gmac
> @@ -310,6 +315,11 @@ allOf:
>                - allwinner,sun8i-r40-emac
>                - allwinner,sun8i-v3s-emac
>                - allwinner,sun50i-a64-emac
> +              - ingenic,jz4775-mac
> +              - ingenic,x1000-mac
> +              - ingenic,x1600-mac
> +              - ingenic,x1830-mac
> +              - ingenic,x2000-mac
>                - snps,dwxgmac
>                - snps,dwxgmac-2.10
>                - st,spear600-gmac
> @@ -353,6 +363,11 @@ allOf:
>                - allwinner,sun8i-r40-emac
>                - allwinner,sun8i-v3s-emac
>                - allwinner,sun50i-a64-emac
> +              - ingenic,jz4775-mac
> +              - ingenic,x1000-mac
> +              - ingenic,x1600-mac
> +              - ingenic,x1830-mac
> +              - ingenic,x2000-mac
>                - snps,dwmac-4.00
>                - snps,dwmac-4.10a
>                - snps,dwmac-4.20a
> --
> 2.7.4
>
Zhou Yanjie June 17, 2021, 3:24 a.m. UTC | #4 
Hi Rob,

于 Wed, 16 Jun 2021 15:45:26 +0800
周琰杰 <zhouyanjie@wanyeetech.com> 写道:

> Hi Rob,

> 

> 于 Tue, 15 Jun 2021 17:05:45 -0600

> Rob Herring <robh+dt@kernel.org> 写道:

> 

> > On Mon, Jun 14, 2021 at 11:18 AM 周琰杰 (Zhou Yanjie)

> > <zhouyanjie@wanyeetech.com> wrote:  

> > >

> > > Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,

> > > the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.

> > >

> > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>

> > > ---

> > >

> > > Notes:

> > >     v1->v2:

> > >     No change.

> > >

> > >     v2->v3:

> > >     Add "ingenic,mac.yaml" for Ingenic SoCs.

> > >

> > >  .../devicetree/bindings/net/ingenic,mac.yaml       | 76

> > > ++++++++++++++++++++++ .../devicetree/bindings/net/snps,dwmac.yaml

> > > | 15 +++++ 2 files changed, 91 insertions(+)

> > >  create mode 100644

> > > Documentation/devicetree/bindings/net/ingenic,mac.yaml

> > >

> > > diff --git

> > > a/Documentation/devicetree/bindings/net/ingenic,mac.yaml

> > > b/Documentation/devicetree/bindings/net/ingenic,mac.yaml new file

> > > mode 100644 index 00000000..5fe2e81 --- /dev/null

> > > +++ b/Documentation/devicetree/bindings/net/ingenic,mac.yaml

> > > @@ -0,0 +1,76 @@

> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

> > > +%YAML 1.2

> > > +---

> > > +$id: http://devicetree.org/schemas/net/ingenic,mac.yaml#

> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#

> > > +

> > > +title: Bindings for MAC in Ingenic SoCs

> > > +

> > > +maintainers:

> > > +  - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>

> > > +

> > > +description:

> > > +  The Ethernet Media Access Controller in Ingenic SoCs.

> > > +

> > > +properties:

> > > +  compatible:

> > > +    enum:

> > > +      - ingenic,jz4775-mac

> > > +      - ingenic,x1000-mac

> > > +      - ingenic,x1600-mac

> > > +      - ingenic,x1830-mac

> > > +      - ingenic,x2000-mac

> > > +

> > > +  reg:

> > > +    maxItems: 1

> > > +

> > > +  interrupts:

> > > +    maxItems: 1

> > > +

> > > +  interrupt-names:

> > > +    const: macirq

> > > +

> > > +  clocks:

> > > +    maxItems: 1

> > > +

> > > +  clock-names:

> > > +    const: stmmaceth

> > > +

> > > +  mode-reg:

> > > +    description: An extra syscon register that control ethernet

> > > interface and timing delay    

> > 

> > Needs a vendor prefix and type.

> >   

> > > +

> > > +  rx-clk-delay-ps:

> > > +    description: RGMII receive clock delay defined in pico

> > > seconds +

> > > +  tx-clk-delay-ps:

> > > +    description: RGMII transmit clock delay defined in pico

> > > seconds +

> > > +required:

> > > +  - compatible

> > > +  - reg

> > > +  - interrupts

> > > +  - interrupt-names

> > > +  - clocks

> > > +  - clock-names

> > > +  - mode-reg

> > > +

> > > +additionalProperties: false

> > > +

> > > +examples:

> > > +  - |

> > > +    #include <dt-bindings/clock/x1000-cgu.h>

> > > +

> > > +    mac: ethernet@134b0000 {

> > > +        compatible = "ingenic,x1000-mac", "snps,dwmac";    

> > 

> > Doesn't match the schema.  

> 

> Sorry for that, somehow when I run "make dt_bindings_check", there is

> no warrning or error message about this file. I am sure that yamllint

> is installed and dtschema has been upgraded to 2021.6.


I found that it seems to be because 5.13 newly introduced
"DT_CHECKER_FLAGS=-m", and I am still using the old
"make dt_binding_check" command, so this error is not prompted. Now I
can see this error message after using the
"make DT_CHECKER_FLAGS=-m dt_binding_check" command, and I will send a
fix soon.

Thanks and best regards!

> 

> I will send a fix.

> 

> Thanks and best regards!

> 

> >   

> > > +        reg = <0x134b0000 0x2000>;

> > > +

> > > +        interrupt-parent = <&intc>;

> > > +        interrupts = <55>;

> > > +        interrupt-names = "macirq";

> > > +

> > > +        clocks = <&cgu X1000_CLK_MAC>;

> > > +        clock-names = "stmmaceth";

> > > +

> > > +        mode-reg = <&mac_phy_ctrl>;

> > > +    };

> > > +...

> > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml

> > > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index

> > > 2edd8be..9c0ce92 100644 ---

> > > a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++

> > > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -56,6

> > > +56,11 @@ properties:

> > >          - amlogic,meson8m2-dwmac

> > >          - amlogic,meson-gxbb-dwmac

> > >          - amlogic,meson-axg-dwmac

> > > +        - ingenic,jz4775-mac

> > > +        - ingenic,x1000-mac

> > > +        - ingenic,x1600-mac

> > > +        - ingenic,x1830-mac

> > > +        - ingenic,x2000-mac

> > >          - rockchip,px30-gmac

> > >          - rockchip,rk3128-gmac

> > >          - rockchip,rk3228-gmac

> > > @@ -310,6 +315,11 @@ allOf:

> > >                - allwinner,sun8i-r40-emac

> > >                - allwinner,sun8i-v3s-emac

> > >                - allwinner,sun50i-a64-emac

> > > +              - ingenic,jz4775-mac

> > > +              - ingenic,x1000-mac

> > > +              - ingenic,x1600-mac

> > > +              - ingenic,x1830-mac

> > > +              - ingenic,x2000-mac

> > >                - snps,dwxgmac

> > >                - snps,dwxgmac-2.10

> > >                - st,spear600-gmac

> > > @@ -353,6 +363,11 @@ allOf:

> > >                - allwinner,sun8i-r40-emac

> > >                - allwinner,sun8i-v3s-emac

> > >                - allwinner,sun50i-a64-emac

> > > +              - ingenic,jz4775-mac

> > > +              - ingenic,x1000-mac

> > > +              - ingenic,x1600-mac

> > > +              - ingenic,x1830-mac

> > > +              - ingenic,x2000-mac

> > >                - snps,dwmac-4.00

> > >                - snps,dwmac-4.10a

> > >                - snps,dwmac-4.20a

> > > --

> > > 2.7.4  

> >
Rob Herring June 18, 2021, 7:50 p.m. UTC | #5 
On Wed, Jun 16, 2021 at 9:24 PM 周琰杰 <zhouyanjie@wanyeetech.com> wrote:
>

> Hi Rob,

>

> 于 Wed, 16 Jun 2021 15:45:26 +0800

> 周琰杰 <zhouyanjie@wanyeetech.com> 写道:

>

> > Hi Rob,

> >

> > 于 Tue, 15 Jun 2021 17:05:45 -0600

> > Rob Herring <robh+dt@kernel.org> 写道:

> >

> > > On Mon, Jun 14, 2021 at 11:18 AM 周琰杰 (Zhou Yanjie)

> > > <zhouyanjie@wanyeetech.com> wrote:

> > > >

> > > > Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,

> > > > the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.

> > > >

> > > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>

> > > > ---

> > > >

> > > > Notes:

> > > >     v1->v2:

> > > >     No change.

> > > >

> > > >     v2->v3:

> > > >     Add "ingenic,mac.yaml" for Ingenic SoCs.

> > > >

> > > >  .../devicetree/bindings/net/ingenic,mac.yaml       | 76

> > > > ++++++++++++++++++++++ .../devicetree/bindings/net/snps,dwmac.yaml

> > > > | 15 +++++ 2 files changed, 91 insertions(+)

> > > >  create mode 100644

> > > > Documentation/devicetree/bindings/net/ingenic,mac.yaml

> > > >

> > > > diff --git

> > > > a/Documentation/devicetree/bindings/net/ingenic,mac.yaml

> > > > b/Documentation/devicetree/bindings/net/ingenic,mac.yaml new file

> > > > mode 100644 index 00000000..5fe2e81 --- /dev/null

> > > > +++ b/Documentation/devicetree/bindings/net/ingenic,mac.yaml

> > > > @@ -0,0 +1,76 @@

> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

> > > > +%YAML 1.2

> > > > +---

> > > > +$id: http://devicetree.org/schemas/net/ingenic,mac.yaml#

> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#

> > > > +

> > > > +title: Bindings for MAC in Ingenic SoCs

> > > > +

> > > > +maintainers:

> > > > +  - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>

> > > > +

> > > > +description:

> > > > +  The Ethernet Media Access Controller in Ingenic SoCs.

> > > > +

> > > > +properties:

> > > > +  compatible:

> > > > +    enum:

> > > > +      - ingenic,jz4775-mac

> > > > +      - ingenic,x1000-mac

> > > > +      - ingenic,x1600-mac

> > > > +      - ingenic,x1830-mac

> > > > +      - ingenic,x2000-mac

> > > > +

> > > > +  reg:

> > > > +    maxItems: 1

> > > > +

> > > > +  interrupts:

> > > > +    maxItems: 1

> > > > +

> > > > +  interrupt-names:

> > > > +    const: macirq

> > > > +

> > > > +  clocks:

> > > > +    maxItems: 1

> > > > +

> > > > +  clock-names:

> > > > +    const: stmmaceth

> > > > +

> > > > +  mode-reg:

> > > > +    description: An extra syscon register that control ethernet

> > > > interface and timing delay

> > >

> > > Needs a vendor prefix and type.

> > >

> > > > +

> > > > +  rx-clk-delay-ps:

> > > > +    description: RGMII receive clock delay defined in pico

> > > > seconds +

> > > > +  tx-clk-delay-ps:

> > > > +    description: RGMII transmit clock delay defined in pico

> > > > seconds +

> > > > +required:

> > > > +  - compatible

> > > > +  - reg

> > > > +  - interrupts

> > > > +  - interrupt-names

> > > > +  - clocks

> > > > +  - clock-names

> > > > +  - mode-reg

> > > > +

> > > > +additionalProperties: false

> > > > +

> > > > +examples:

> > > > +  - |

> > > > +    #include <dt-bindings/clock/x1000-cgu.h>

> > > > +

> > > > +    mac: ethernet@134b0000 {

> > > > +        compatible = "ingenic,x1000-mac", "snps,dwmac";

> > >

> > > Doesn't match the schema.

> >

> > Sorry for that, somehow when I run "make dt_bindings_check", there is

> > no warrning or error message about this file. I am sure that yamllint

> > is installed and dtschema has been upgraded to 2021.6.

>

> I found that it seems to be because 5.13 newly introduced

> "DT_CHECKER_FLAGS=-m", and I am still using the old

> "make dt_binding_check" command, so this error is not prompted. Now I

> can see this error message after using the

> "make DT_CHECKER_FLAGS=-m dt_binding_check" command, and I will send a

> fix soon.


No, this error has nothing to do with the '-m' option.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/ingenic,mac.yaml b/Documentation/devicetree/bindings/net/ingenic,mac.yaml
new file mode 100644
index 00000000..5fe2e81
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/ingenic,mac.yaml
@@ -0,0 +1,76 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/ingenic,mac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bindings for MAC in Ingenic SoCs
+
+maintainers:
+  - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
+
+description:
+  The Ethernet Media Access Controller in Ingenic SoCs.
+
+properties:
+  compatible:
+    enum:
+      - ingenic,jz4775-mac
+      - ingenic,x1000-mac
+      - ingenic,x1600-mac
+      - ingenic,x1830-mac
+      - ingenic,x2000-mac
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    const: macirq
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: stmmaceth
+
+  mode-reg:
+    description: An extra syscon register that control ethernet interface and timing delay
+
+  rx-clk-delay-ps:
+    description: RGMII receive clock delay defined in pico seconds
+
+  tx-clk-delay-ps:
+    description: RGMII transmit clock delay defined in pico seconds
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+  - clocks
+  - clock-names
+  - mode-reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/x1000-cgu.h>
+
+    mac: ethernet@134b0000 {
+        compatible = "ingenic,x1000-mac", "snps,dwmac";
+        reg = <0x134b0000 0x2000>;
+
+        interrupt-parent = <&intc>;
+        interrupts = <55>;
+        interrupt-names = "macirq";
+
+        clocks = <&cgu X1000_CLK_MAC>;
+        clock-names = "stmmaceth";
+
+        mode-reg = <&mac_phy_ctrl>;
+    };
+...
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 2edd8be..9c0ce92 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -56,6 +56,11 @@  properties:
         - amlogic,meson8m2-dwmac
         - amlogic,meson-gxbb-dwmac
         - amlogic,meson-axg-dwmac
+        - ingenic,jz4775-mac
+        - ingenic,x1000-mac
+        - ingenic,x1600-mac
+        - ingenic,x1830-mac
+        - ingenic,x2000-mac
         - rockchip,px30-gmac
         - rockchip,rk3128-gmac
         - rockchip,rk3228-gmac
@@ -310,6 +315,11 @@  allOf:
               - allwinner,sun8i-r40-emac
               - allwinner,sun8i-v3s-emac
               - allwinner,sun50i-a64-emac
+              - ingenic,jz4775-mac
+              - ingenic,x1000-mac
+              - ingenic,x1600-mac
+              - ingenic,x1830-mac
+              - ingenic,x2000-mac
               - snps,dwxgmac
               - snps,dwxgmac-2.10
               - st,spear600-gmac
@@ -353,6 +363,11 @@  allOf:
               - allwinner,sun8i-r40-emac
               - allwinner,sun8i-v3s-emac
               - allwinner,sun50i-a64-emac
+              - ingenic,jz4775-mac
+              - ingenic,x1000-mac
+              - ingenic,x1600-mac
+              - ingenic,x1830-mac
+              - ingenic,x2000-mac
               - snps,dwmac-4.00
               - snps,dwmac-4.10a
               - snps,dwmac-4.20a