[-next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static

Message ID 20210615172156.2840576-1-weiyongjun1@huawei.com
State New
Headers show
Series
  • [-next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static
Related show

Commit Message

Wei Yongjun June 15, 2021, 5:21 p.m.
The sparse tool complains as follows:

sound/soc/codecs/hdmi-codec.c:750:25: warning:
 symbol 'hdmi_codec_controls' was not declared. Should it be static?

This symbol is not used outside of hdmi-codec.c, so marks it static.

Fixes: 366b45b97448 ("ASoC: hdmi-codec: Rework to support more controls")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 sound/soc/codecs/hdmi-codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Ripard June 16, 2021, 8:21 a.m. | #1
On Tue, Jun 15, 2021 at 05:21:56PM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> sound/soc/codecs/hdmi-codec.c:750:25: warning:
>  symbol 'hdmi_codec_controls' was not declared. Should it be static?
> 
> This symbol is not used outside of hdmi-codec.c, so marks it static.
> 
> Fixes: 366b45b97448 ("ASoC: hdmi-codec: Rework to support more controls")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Acked-by: Maxime Ripard <maxime@cerno.tech>

Thanks!
Maxime

Patch

diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
index e0460a9bd17a..b61f980cabdc 100644
--- a/sound/soc/codecs/hdmi-codec.c
+++ b/sound/soc/codecs/hdmi-codec.c
@@ -747,7 +747,7 @@  static const struct snd_soc_dai_ops hdmi_codec_spdif_dai_ops = {
 			 SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_S32_BE |\
 			 SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE)
 
-struct snd_kcontrol_new hdmi_codec_controls[] = {
+static struct snd_kcontrol_new hdmi_codec_controls[] = {
 	{
 		.access = SNDRV_CTL_ELEM_ACCESS_READ,
 		.iface = SNDRV_CTL_ELEM_IFACE_PCM,