From patchwork Wed Jun 16 06:37:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 461359 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312880jae; Tue, 15 Jun 2021 23:37:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyu9c2dwDFg0iTLI4IfU3aJfltN0kLhmuTkatN4AEL4lJaKFK2OmCS7FtWNCrgAgLH4U+Mw X-Received: by 2002:a17:906:1c4e:: with SMTP id l14mr3646550ejg.172.1623825479069; Tue, 15 Jun 2021 23:37:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825479; cv=none; d=google.com; s=arc-20160816; b=Wml88VVZ47rchg7EMuMEop7+v7n8JD9Wn9sl6z+qO90/UNqr4AGQOFRSQoHJ2yFHHp WGhOQRmxC0usabaIWG4viG7d4TnxwkTNg435IzLlyxr7w/y/evWpc3VCfAOmx0HIPcZ6 wOYEb5Ori0Tl3HpctrUG2nzY+kzjaJoM9SKzCSFgQQc8DnvYB/yOL5mJHE9HQUWjXudB BY02NvEnIu8XM5DrA6sdWQrVAdR4uHyB0DfG+uh1vf53Jgv3UkeE754z+REkP1cMBm2j iG8V3JRa0SNM9+TjqynB0GK5bRZRASDrxsM1gW4GtISS4mX4JRnyj6J4+9T8q645g6bH wd9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=98sI03NMqwlHyVYkpzQrazhFhteRKIYncCyIHwbVeP4=; b=kyJs8rpyGX3LP+UbM7djVjaq/YlVerIXHmIFj/JnhF/p0VdAlY0CWcDues2Ux62+wq t03QHjzI67mxDezqnoCnYWCsf0YhEB/Fg4lqf162xQjgTHja3zE+vUSGawGPzgGPntN3 lIOXIeFAzK6mnsxKwo5iWrhtCKRzWSOFMqTKeLweqAUmainSrzW54ToF2i2LKjCQX1hV JrgcREUsWoOf5s21sGp5ZQ60Ij9vbzWVXXTubWaqtO2ntKbrWldNRIvUwxQp13mvHCVc sQbiLLLB/K4hl5aT8sBJ2lLZ/PNUrh/qk/ZthJvEzSjP9j0Be4hqxZcKQUF6Vaa45//B 0Zjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.37.58 for ; Tue, 15 Jun 2021 23:37:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231446AbhFPGkD (ORCPT ); Wed, 16 Jun 2021 02:40:03 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7323 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhFPGkC (ORCPT ); Wed, 16 Jun 2021 02:40:02 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G4b4P0sjFz6y9v; Wed, 16 Jun 2021 14:33:57 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:56 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:55 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 07/20] scsi: tcm_qla2xxx: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:01 +0800 Message-ID: <20210616063714.778-8-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index 03de1bcf1461d77..d537a7bc27f08b0 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c @@ -1035,10 +1035,8 @@ static struct se_portal_group *tcm_qla2xxx_make_tpg(struct se_wwn *wwn, } tpg = kzalloc(sizeof(struct tcm_qla2xxx_tpg), GFP_KERNEL); - if (!tpg) { - pr_err("Unable to allocate struct tcm_qla2xxx_tpg\n"); + if (!tpg) return ERR_PTR(-ENOMEM); - } tpg->lport = lport; tpg->lport_tpgt = tpgt; /* @@ -1151,10 +1149,8 @@ static struct se_portal_group *tcm_qla2xxx_npiv_make_tpg(struct se_wwn *wwn, return ERR_PTR(-EINVAL); tpg = kzalloc(sizeof(struct tcm_qla2xxx_tpg), GFP_KERNEL); - if (!tpg) { - pr_err("Unable to allocate struct tcm_qla2xxx_tpg\n"); + if (!tpg) return ERR_PTR(-ENOMEM); - } tpg->lport = lport; tpg->lport_tpgt = tpgt; @@ -1653,10 +1649,8 @@ static struct se_wwn *tcm_qla2xxx_make_lport( return ERR_PTR(-EINVAL); lport = kzalloc(sizeof(struct tcm_qla2xxx_lport), GFP_KERNEL); - if (!lport) { - pr_err("Unable to allocate struct tcm_qla2xxx_lport\n"); + if (!lport) return ERR_PTR(-ENOMEM); - } lport->lport_wwpn = wwpn; tcm_qla2xxx_format_wwn(&lport->lport_name[0], TCM_QLA2XXX_NAMELEN, wwpn); @@ -1779,10 +1773,8 @@ static struct se_wwn *tcm_qla2xxx_npiv_make_lport( return ERR_PTR(-EINVAL); lport = kzalloc(sizeof(struct tcm_qla2xxx_lport), GFP_KERNEL); - if (!lport) { - pr_err("Unable to allocate struct tcm_qla2xxx_lport for NPIV\n"); + if (!lport) return ERR_PTR(-ENOMEM); - } lport->lport_npiv_wwpn = npiv_wwpn; lport->lport_npiv_wwnn = npiv_wwnn; sprintf(lport->lport_naa_name, "naa.%016llx", (unsigned long long) npiv_wwpn);