From patchwork Wed Jun 16 06:37:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 461371 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp313117jae; Tue, 15 Jun 2021 23:38:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx455oJ7bgIVO9qtNneOl62BhFkud6T90gc6RT6PjNsX4iw5R/9s+7uShkQY1BJCs0JNda+ X-Received: by 2002:aa7:d388:: with SMTP id x8mr2229025edq.338.1623825496621; Tue, 15 Jun 2021 23:38:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825496; cv=none; d=google.com; s=arc-20160816; b=K3r58nps09I+Jllb0K90LOTJ4pivFV6vfusWza3iDzS5RIvG47ONtCtH6Dn+XSjBY1 Wzu84LHoOQoAvKFlyfQMnmPeeV/rnfMB21ykJchnu2GlP0m4a6AanAOlAShZihm7qZkt lf8/OYvMklW9nb2wDhuzgH6x3NB/CkZ2WkO6qxlI/9Jux5P1gPQmaQ0lqVicZUxOC7SI UVz3LA9CN7Avznm2ViASIAeifyGs5p/6xpWdjuswdZmmG92AK2NHuaFVy5Ik+zmG3TbF myCWLVkDkeZmlkVmh++x/MF1ypwUZ+rpb68OqCy9xnab5kvboLaEPMm4lsJ2plu4o4X9 p3fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=BVistbDCF39pBvmdkf1UPOW+yZvsM64xCqQCTnU530A=; b=l/RsHGu94kloRg2dGciyg07PnrdhKRxHMKUKaeyZz2msTOe6QzX5KF5wgNdCkDJYBn i4hniZU1QwyysOpcI+eWidU+QAMEmuynrtL6KzDYanD9j+dh+Sgkt/KqWU64EGbBH3p0 N/xXsbd66SfZFp1hYoq32qI2Ui8Bv8SAsP2CX8B1ryY89lCDpBJ3Dytqo2us+j5ZykUm KuFUzFaB8uDajfQWUbXZLuvKJfgO9ENsJsaYLlirBR9/fekVE0KTkTz3acf/qmRSatXC 6fQYfvQKMGBtUTIMP3yBscfg76L0suwPzJRJKZeJSr2FOZs4mWuQ1s0BYemRndkmRfxn QnSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.16 for ; Tue, 15 Jun 2021 23:38:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231589AbhFPGkV (ORCPT ); Wed, 16 Jun 2021 02:40:21 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7325 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231644AbhFPGkT (ORCPT ); Wed, 16 Jun 2021 02:40:19 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G4b4j2Lpgz6y7X; Wed, 16 Jun 2021 14:34:13 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:04 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:03 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 17/20] scsi: aic94xx: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:11 +0800 Message-ID: <20210616063714.778-18-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/aic94xx/aic94xx_init.c | 4 +--- drivers/scsi/aic94xx/aic94xx_sds.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c index a195bfe9eccc073..9edd6008bbdec03 100644 --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b/drivers/scsi/aic94xx/aic94xx_init.c @@ -725,10 +725,8 @@ static int asd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) asd_dev = &asd_pcidev_data[asd_id]; asd_ha = kzalloc(sizeof(*asd_ha), GFP_KERNEL); - if (!asd_ha) { - asd_printk("out of memory\n"); + if (!asd_ha) goto Err_put; - } asd_ha->pcidev = dev; asd_ha->sas_ha.dev = &asd_ha->pcidev->dev; asd_ha->sas_ha.lldd_ha = asd_ha; diff --git a/drivers/scsi/aic94xx/aic94xx_sds.c b/drivers/scsi/aic94xx/aic94xx_sds.c index 297a66770260ccf..1b46f0018e0bfe5 100644 --- a/drivers/scsi/aic94xx/aic94xx_sds.c +++ b/drivers/scsi/aic94xx/aic94xx_sds.c @@ -342,10 +342,8 @@ int asd_read_ocm(struct asd_ha_struct *asd_ha) return -1; dir = kmalloc(sizeof(*dir), GFP_KERNEL); - if (!dir) { - asd_printk("no memory for ocm dir\n"); + if (!dir) return -ENOMEM; - } err = asd_read_ocm_dir(asd_ha, dir, 0); if (err)