| Message ID | 1623865378-1943-1-git-send-email-sibis@codeaurora.org |
|---|---|
| State | Accepted |
| Commit | d6fbfdbc12745ce24bcd348dbf7e652353b3e59c |
| Headers | show |
| Series | mailbox: qcom-ipcc: Fix IPCC mbox channel exhaustion | expand |
On Wed 16 Jun 12:42 CDT 2021, Sibi Sankar wrote: > Fix IPCC (Inter-Processor Communication Controller) channel exhaustion by > setting the channel private data to NULL on mbox shutdown. > > Err Logs: > remoteproc: MBA booted without debug policy, loading mpss > remoteproc: glink-edge: failed to acquire IPC channel > remoteproc: failed to probe subdevices for remoteproc: -16 > > Fixes: fa74a0257f45 ("mailbox: Add support for Qualcomm IPCC") > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > Cc: stable@vger.kernel.org Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/mailbox/qcom-ipcc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c > index 2d13c72944c6..584700cd1585 100644 > --- a/drivers/mailbox/qcom-ipcc.c > +++ b/drivers/mailbox/qcom-ipcc.c > @@ -155,6 +155,11 @@ static int qcom_ipcc_mbox_send_data(struct mbox_chan *chan, void *data) > return 0; > } > > +static void qcom_ipcc_mbox_shutdown(struct mbox_chan *chan) > +{ > + chan->con_priv = NULL; > +} > + > static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox, > const struct of_phandle_args *ph) > { > @@ -184,6 +189,7 @@ static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox, > > static const struct mbox_chan_ops ipcc_mbox_chan_ops = { > .send_data = qcom_ipcc_mbox_send_data, > + .shutdown = qcom_ipcc_mbox_shutdown, > }; > > static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
On Wed, Jun 16, 2021 at 11:12:58PM +0530, Sibi Sankar wrote: > Fix IPCC (Inter-Processor Communication Controller) channel exhaustion by > setting the channel private data to NULL on mbox shutdown. > > Err Logs: > remoteproc: MBA booted without debug policy, loading mpss > remoteproc: glink-edge: failed to acquire IPC channel > remoteproc: failed to probe subdevices for remoteproc: -16 > > Fixes: fa74a0257f45 ("mailbox: Add support for Qualcomm IPCC") > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > Cc: stable@vger.kernel.org > --- > drivers/mailbox/qcom-ipcc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c > index 2d13c72944c6..584700cd1585 100644 > --- a/drivers/mailbox/qcom-ipcc.c > +++ b/drivers/mailbox/qcom-ipcc.c > @@ -155,6 +155,11 @@ static int qcom_ipcc_mbox_send_data(struct mbox_chan *chan, void *data) > return 0; > } > > +static void qcom_ipcc_mbox_shutdown(struct mbox_chan *chan) > +{ > + chan->con_priv = NULL; > +} > + > static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox, > const struct of_phandle_args *ph) > { > @@ -184,6 +189,7 @@ static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox, > > static const struct mbox_chan_ops ipcc_mbox_chan_ops = { > .send_data = qcom_ipcc_mbox_send_data, > + .shutdown = qcom_ipcc_mbox_shutdown, > }; > > static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c index 2d13c72944c6..584700cd1585 100644 --- a/drivers/mailbox/qcom-ipcc.c +++ b/drivers/mailbox/qcom-ipcc.c @@ -155,6 +155,11 @@ static int qcom_ipcc_mbox_send_data(struct mbox_chan *chan, void *data) return 0; } +static void qcom_ipcc_mbox_shutdown(struct mbox_chan *chan) +{ + chan->con_priv = NULL; +} + static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox, const struct of_phandle_args *ph) { @@ -184,6 +189,7 @@ static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox, static const struct mbox_chan_ops ipcc_mbox_chan_ops = { .send_data = qcom_ipcc_mbox_send_data, + .shutdown = qcom_ipcc_mbox_shutdown, }; static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc)
Fix IPCC (Inter-Processor Communication Controller) channel exhaustion by setting the channel private data to NULL on mbox shutdown. Err Logs: remoteproc: MBA booted without debug policy, loading mpss remoteproc: glink-edge: failed to acquire IPC channel remoteproc: failed to probe subdevices for remoteproc: -16 Fixes: fa74a0257f45 ("mailbox: Add support for Qualcomm IPCC") Signed-off-by: Sibi Sankar <sibis@codeaurora.org> Cc: stable@vger.kernel.org --- drivers/mailbox/qcom-ipcc.c | 6 ++++++ 1 file changed, 6 insertions(+)