[net-next,7/8] net: hdlc_ppp: remove redundant spaces

Message ID 1623836037-26812-8-git-send-email-huangguangbin2@huawei.com
State New
Headers show
Series
  • net: hdlc_ppp: clean up some code style issues
Related show

Commit Message

Guangbin Huang June 16, 2021, 9:33 a.m.
From: Peng Li <lipeng321@huawei.com>

According to the chackpatch.pl,
no spaces is necessary at the start of a line.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_ppp.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Peng Li June 17, 2021, 1:05 a.m. | #1
在 2021/6/17 0:23, Andrew Lunn 写道:
> On Wed, Jun 16, 2021 at 05:33:56PM +0800, Guangbin Huang wrote:

>> From: Peng Li <lipeng321@huawei.com>

>>

>> According to the chackpatch.pl,

>> no spaces is necessary at the start of a line.

>>

>> Signed-off-by: Peng Li <lipeng321@huawei.com>

>> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>

>> ---

>>   drivers/net/wan/hdlc_ppp.c | 10 +++++-----

>>   1 file changed, 5 insertions(+), 5 deletions(-)

>>

>> diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c

>> index 7b7c02d..53c668e 100644

>> --- a/drivers/net/wan/hdlc_ppp.c

>> +++ b/drivers/net/wan/hdlc_ppp.c

>> @@ -34,8 +34,8 @@

>>   

>>   enum {IDX_LCP = 0, IDX_IPCP, IDX_IPV6CP, IDX_COUNT};

>>   enum {CP_CONF_REQ = 1, CP_CONF_ACK, CP_CONF_NAK, CP_CONF_REJ, CP_TERM_REQ,

>> -      CP_TERM_ACK, CP_CODE_REJ, LCP_PROTO_REJ, LCP_ECHO_REQ, LCP_ECHO_REPLY,

>> -      LCP_DISC_REQ, CP_CODES};

>> +	CP_TERM_ACK, CP_CODE_REJ, LCP_PROTO_REJ, LCP_ECHO_REQ, LCP_ECHO_REPLY,

>> +	LCP_DISC_REQ, CP_CODES};

> Do you think this looks better or worse after the change?

>

>     Andrew

> .


It is better after the change as the code style follow the same rule.

What's your suggestion?

Patch

diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
index 7b7c02d..53c668e 100644
--- a/drivers/net/wan/hdlc_ppp.c
+++ b/drivers/net/wan/hdlc_ppp.c
@@ -34,8 +34,8 @@ 
 
 enum {IDX_LCP = 0, IDX_IPCP, IDX_IPV6CP, IDX_COUNT};
 enum {CP_CONF_REQ = 1, CP_CONF_ACK, CP_CONF_NAK, CP_CONF_REJ, CP_TERM_REQ,
-      CP_TERM_ACK, CP_CODE_REJ, LCP_PROTO_REJ, LCP_ECHO_REQ, LCP_ECHO_REPLY,
-      LCP_DISC_REQ, CP_CODES};
+	CP_TERM_ACK, CP_CODE_REJ, LCP_PROTO_REJ, LCP_ECHO_REQ, LCP_ECHO_REPLY,
+	LCP_DISC_REQ, CP_CODES};
 #if DEBUG_CP
 static const char *const code_names[CP_CODES] = {
 	"0", "ConfReq", "ConfAck", "ConfNak", "ConfRej", "TermReq",
@@ -80,11 +80,11 @@  struct ppp {
 };
 
 enum {CLOSED = 0, STOPPED, STOPPING, REQ_SENT, ACK_RECV, ACK_SENT, OPENED,
-      STATES, STATE_MASK = 0xF};
+	STATES, STATE_MASK = 0xF};
 enum {START = 0, STOP, TO_GOOD, TO_BAD, RCR_GOOD, RCR_BAD, RCA, RCN, RTR, RTA,
-      RUC, RXJ_GOOD, RXJ_BAD, EVENTS};
+	RUC, RXJ_GOOD, RXJ_BAD, EVENTS};
 enum {INV = 0x10, IRC = 0x20, ZRC = 0x40, SCR = 0x80, SCA = 0x100,
-      SCN = 0x200, STR = 0x400, STA = 0x800, SCJ = 0x1000};
+	SCN = 0x200, STR = 0x400, STA = 0x800, SCJ = 0x1000};
 
 #if DEBUG_STATE
 static const char *const state_names[STATES] = {