| Message ID | 1623811148-11064-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] net: stmmac: Fix an error code in dwmac-ingenic.c | expand |
On Wed, Jun 16, 2021 at 10:39:08AM +0800, Yang Li wrote: > When IS_ERR(mac->regmap) returns true, the value of ret is 0. > So, we set ret to -ENODEV to indicate this error. > > Clean up smatch warning: > drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c:266 > ingenic_mac_probe() warn: missing error code 'ret' > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c > index 60984c1..f3950e0 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c > @@ -263,6 +263,7 @@ static int ingenic_mac_probe(struct platform_device *pdev) > mac->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "mode-reg"); > if (IS_ERR(mac->regmap)) { > dev_err(&pdev->dev, "%s: Failed to get syscon regmap\n", __func__); > + ret = -ENODEV; mac->regmap is a ERR_PTR(), containing an error code. Please use that error code, not ENODEV. Andrew
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c index 60984c1..f3950e0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c @@ -263,6 +263,7 @@ static int ingenic_mac_probe(struct platform_device *pdev) mac->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "mode-reg"); if (IS_ERR(mac->regmap)) { dev_err(&pdev->dev, "%s: Failed to get syscon regmap\n", __func__); + ret = -ENODEV; goto err_remove_config_dt; }
When IS_ERR(mac->regmap) returns true, the value of ret is 0. So, we set ret to -ENODEV to indicate this error. Clean up smatch warning: drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c:266 ingenic_mac_probe() warn: missing error code 'ret' Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c | 1 + 1 file changed, 1 insertion(+)