diff mbox series

[-next,3/4] ASoC: samsung: s3c2412-i2s: Use devm_platform_get_and_ioremap_resource()

Message ID 20210616091652.2552927-4-yangyingliang@huawei.com
State Accepted
Commit 87a32d00249e6e3c6b1ac020d36136b2cd75fcc8
Headers show
Series ASoC: samsung: Use devm_platform_get_and_ioremap_resource() | expand

Commit Message

Yang Yingliang June 16, 2021, 9:16 a.m. UTC
Use devm_platform_get_and_ioremap_resource() to simplify
code.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 sound/soc/samsung/s3c2412-i2s.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Krzysztof Kozlowski June 21, 2021, 9:22 a.m. UTC | #1
On 16/06/2021 11:16, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  sound/soc/samsung/s3c2412-i2s.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/samsung/s3c2412-i2s.c b/sound/soc/samsung/s3c2412-i2s.c
> index 81f416ac457e..ec1c6f9d76ac 100644
> --- a/sound/soc/samsung/s3c2412-i2s.c
> +++ b/sound/soc/samsung/s3c2412-i2s.c
> @@ -208,8 +208,7 @@ static int s3c2412_iis_dev_probe(struct platform_device *pdev)
>  		return -ENXIO;
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	s3c2412_i2s.regs = devm_ioremap_resource(&pdev->dev, res);
> +	s3c2412_i2s.regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>  	if (IS_ERR(s3c2412_i2s.regs))
>  		return PTR_ERR(s3c2412_i2s.regs);
>  
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/sound/soc/samsung/s3c2412-i2s.c b/sound/soc/samsung/s3c2412-i2s.c
index 81f416ac457e..ec1c6f9d76ac 100644
--- a/sound/soc/samsung/s3c2412-i2s.c
+++ b/sound/soc/samsung/s3c2412-i2s.c
@@ -208,8 +208,7 @@  static int s3c2412_iis_dev_probe(struct platform_device *pdev)
 		return -ENXIO;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	s3c2412_i2s.regs = devm_ioremap_resource(&pdev->dev, res);
+	s3c2412_i2s.regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(s3c2412_i2s.regs))
 		return PTR_ERR(s3c2412_i2s.regs);