Message ID | 20210619225118.1862634-3-linus.walleij@linaro.org |
---|---|
State | Superseded |
Headers | show
Delivered-To: patch@linaro.org Received: by 2002:a05:6638:102:0:0:0:0 with SMTP id x2csp1191648jao; Sat, 19 Jun 2021 15:54:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyapS2O7+2kBzz2XPR0+g8BSXuM3Ywsu7Kfa5UctgDL3mthP972YPfBxH0Dl68+trneF2JI X-Received: by 2002:a05:6402:11cc:: with SMTP id j12mr12995626edw.114.1624143257053; Sat, 19 Jun 2021 15:54:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624143257; cv=none; d=google.com; s=arc-20160816; b=mar2r+/ip+JkNL08CHif80XqVmHLF2SW3KAmoOZgTcQtAt9x/fRMjXbJXZy8lcl0st 9CP1dnvblgG8Fan+4S+9FxxPDcFEuLR0+G+sLPpcLOOCDrwrSMeq++qad8Snd38E7P3P iApeKoozBOBwGK3zWwSwf/+j0r2fh51I2bDk3yJA7qUXJVnwxn+7fzmTK9qOZu1sB8UZ a6ImBfMm5ixttdYbyhYFTQd2Z2wM+9dLsr1zSpPLMKOO/G0RrAZdXfRAH1p3vwNFA3dD hgxUQBu3O3JOe+rzMlyLDqrFrkHFcxdOeLFzu71QHwQpU5WtEHk+eeoxTvcKgFDW49F4 KIXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=J4O/PSg42XQGCFuaHFKksTpyRyVdPtGQ1Rdj/uH+UqA=; b=z5EHrxyO98i+GIT9QA8W76//DBGCYv2GfRWpv4CzqjvnlkuUvy4GErgj9bH+bXp8Yl 4i1txXVhKPM5siVhVzNVJUNe7vh/S1oh30UqsGHcqp21WEQmCOwTm+zw2E6623v23Amv VTOiVMFoF0WruDEAK5jJ9Jc/vcIlqK3liEYKDQ/OBMTnzDGQCMe8FCjXypLYwq4DXe3g G6AG3SYajebc6SgA1qIv7Lu1AL5nOlBOoJ1pl4xJod3cqxfLIOeHy3D7aMdGgWt6iGcM OsAH4mMSIdld6wrC4vX6YnLZv2fzWea7DGCZg2CxaHRT0IaLq6WYQA5lIYuqL4ikMaZE p0Dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nnYlDJV7; spf=pass (google.com: domain of linux-mmc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: <linux-mmc-owner@vger.kernel.org> Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q19si2242965edc.164.2021.06.19.15.54.16; Sat, 19 Jun 2021 15:54:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-mmc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nnYlDJV7; spf=pass (google.com: domain of linux-mmc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229522AbhFSW4X (ORCPT <rfc822;naresh.kamboju@linaro.org> + 4 others); Sat, 19 Jun 2021 18:56:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbhFSW4U (ORCPT <rfc822; linux-mmc@vger.kernel.org>); Sat, 19 Jun 2021 18:56:20 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1A63C061756 for <linux-mmc@vger.kernel.org>; Sat, 19 Jun 2021 15:54:08 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id m21so23206445lfg.13 for <linux-mmc@vger.kernel.org>; Sat, 19 Jun 2021 15:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J4O/PSg42XQGCFuaHFKksTpyRyVdPtGQ1Rdj/uH+UqA=; b=nnYlDJV7lF+OmF4cNajdGrn/NgWZCzgPHuiMJ6lnF9trRrHXMMVKH3Oz5wxIAQ4wtL yWDMKhycSDwRyaXkkqMbWfBNO8gx2Xb10I3oJj2DXSEfc4Savwni3KUB7Canea7IIxyV GHzv/DnGmUTzfnEQQ+mktoaFSHMlikRuhnTYXhRAwFoQ+Fkjfuk/WIK6LQ263lLa9gB4 9IRJgsWJEh7YDr5C0W1QAXr9m/vcKluRI+zDHzXpo+lF+q+6abBuygU88yFGxUcbcmM+ qqxzA5BGaNVXOOhyVd+xQvd3JB6oIDmlxOcbtdJDczSa4Qhq9DKBGO2zYWBqTred8cdO wxmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J4O/PSg42XQGCFuaHFKksTpyRyVdPtGQ1Rdj/uH+UqA=; b=CD7dSJ7kkCpohzv0grRzbAbCqmPqDsknu2hkR3RnWfQG+XKU1AnmRatuLMKXEbNF23 Cwykw+s3xYv5QL1GWmE+Mwr+NnArZWwX9e/llHXNNrEh3CqKmxUWhPHMGJREE9Z4TtdY ZWJ1GYdIZiLlBvfDZ37hkHMFqnYGd8lQ8rpqOfqtls2l7Mzp05rOaUKsriksRMrn/RHq /jYDqS1hjaZmthe/4Egj/AvogmMdMKNWQ2bYHVO6Bir8lWJtT4AH4vTkSXOpiOn1XApE DiMFdWvYLztriZRDANlBdt6JEmV0PNuAoJ+Ilo+soX1R2vEQXVWUpDPRsrSuxB5mHbmw v/tg== X-Gm-Message-State: AOAM531aOKUhkKXZ+OHUaB3TR++25tVpfi442GN71jeJDhv6yqxQrPqE IGjTWk9yEy2Ue80kaDWeBIqDwhvzcNN2Ug== X-Received: by 2002:a19:c753:: with SMTP id x80mr6935805lff.200.1624143247150; Sat, 19 Jun 2021 15:54:07 -0700 (PDT) Received: from localhost.localdomain (c-fdcc225c.014-348-6c756e10.bbcust.telenor.se. [92.34.204.253]) by smtp.gmail.com with ESMTPSA id y5sm1345349lfa.148.2021.06.19.15.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jun 2021 15:54:06 -0700 (PDT) From: Linus Walleij <linus.walleij@linaro.org> To: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org>, Russell King <linux@armlinux.org.uk>, Yann Gautier <yann.gautier@foss.st.com>, Ludovic Barre <ludovic.barre@st.com> Subject: [PATCH 3/3] mmc: mmci: Add small comment about reset thread Date: Sun, 20 Jun 2021 00:51:18 +0200 Message-Id: <20210619225118.1862634-3-linus.walleij@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210619225118.1862634-1-linus.walleij@linaro.org> References: <20210619225118.1862634-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-mmc.vger.kernel.org> X-Mailing-List: linux-mmc@vger.kernel.org |
Series |
[1/3] mmc: mmci: De-assert reset on probe
|
expand
|
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index 97fa5e67ca0c..b646ba7f4e10 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c @@ -1394,6 +1394,10 @@ mmci_cmd_irq(struct mmci_host *host, struct mmc_command *cmd, } else if (host->variant->busy_timeout && busy_resp && status & MCI_DATATIMEOUT) { cmd->error = -ETIMEDOUT; + /* + * This will wake up mmci_irq_thread() which will issue + * a hardware reset of the MMCI block. + */ host->irq_action = IRQ_WAKE_THREAD; } else { cmd->resp[0] = readl(base + MMCIRESPONSE0);
Put a small comment before assigning IRQ_WAKE_THREAD telling us what is going on. Cc: Russell King <linux@armlinux.org.uk> Cc: Yann Gautier <yann.gautier@foss.st.com> Cc: Ludovic Barre <ludovic.barre@st.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/mmc/host/mmci.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.31.1