| Message ID | YM32XksFPUbN2Oyi@mwanda |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] net: iosm: remove an unnecessary NULL check | expand |
> The address of &ipc_mux->ul_adb can't be NULL because it points to the > middle of a non-NULL struct. > > Fixes: 9413491e20e1 ("net: iosm: encode or decode datagram") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 19 Jun 2021 16:51:26 +0300 you wrote: > The address of &ipc_mux->ul_adb can't be NULL because it points to the > middle of a non-NULL struct. > > Fixes: 9413491e20e1 ("net: iosm: encode or decode datagram") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] net: iosm: remove an unnecessary NULL check https://git.kernel.org/netdev/net-next/c/d5fff4629bea You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c index fbf3cab3394c..e634ffc6ec08 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c +++ b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c @@ -477,7 +477,7 @@ static void ipc_mux_ul_adgh_finish(struct iosm_mux *ipc_mux) long long bytes; char *str; - if (!ul_adb || !ul_adb->dest_skb) { + if (!ul_adb->dest_skb) { dev_err(ipc_mux->dev, "no dest skb"); return; }
The address of &ipc_mux->ul_adb can't be NULL because it points to the middle of a non-NULL struct. Fixes: 9413491e20e1 ("net: iosm: encode or decode datagram") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)