[v1,2/5] hw/arm: add dependency on OR_IRQ for XLNX_VERSAL

Message ID 20210621152120.4465-3-alex.bennee@linaro.org
State Superseded
Headers show
Series
  • custom device configs (split from larger series)
Related show

Commit Message

Alex Bennée June 21, 2021, 3:21 p.m.
We need this functionality due to:

    /* XRAM IRQs get ORed into a single line.  */
    object_initialize_child(OBJECT(s), "xram-irq-orgate",
                            &s->lpd.xram.irq_orgate, TYPE_OR_IRQ);

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 hw/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1

Comments

Philippe Mathieu-Daudé June 21, 2021, 7 p.m. | #1
On 6/21/21 5:21 PM, Alex Bennée wrote:
> We need this functionality due to:

> 

>     /* XRAM IRQs get ORed into a single line.  */

>     object_initialize_child(OBJECT(s), "xram-irq-orgate",

>                             &s->lpd.xram.irq_orgate, TYPE_OR_IRQ);

> 


Fixes: a55b441b2ca ("hw/arm: versal: Add support for the XRAMs")

> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  hw/arm/Kconfig | 1 +

>  1 file changed, 1 insertion(+)
Edgar E. Iglesias June 21, 2021, 8 p.m. | #2
On Mon, Jun 21, 2021 at 09:00:22PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/21/21 5:21 PM, Alex Bennée wrote:

> > We need this functionality due to:

> > 

> >     /* XRAM IRQs get ORed into a single line.  */

> >     object_initialize_child(OBJECT(s), "xram-irq-orgate",

> >                             &s->lpd.xram.irq_orgate, TYPE_OR_IRQ);

> > 

> 

> Fixes: a55b441b2ca ("hw/arm: versal: Add support for the XRAMs")

> 

> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> 

> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Thomas Huth July 6, 2021, 10:53 a.m. | #3
On 21/06/2021 17.21, Alex Bennée wrote:
> We need this functionality due to:

> 

>      /* XRAM IRQs get ORed into a single line.  */

>      object_initialize_child(OBJECT(s), "xram-irq-orgate",

>                              &s->lpd.xram.irq_orgate, TYPE_OR_IRQ);

> 

> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>   hw/arm/Kconfig | 1 +

>   1 file changed, 1 insertion(+)

> 

> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig

> index 647b5c8b43..528f71bb9d 100644

> --- a/hw/arm/Kconfig

> +++ b/hw/arm/Kconfig

> @@ -368,6 +368,7 @@ config XLNX_VERSAL

>       select UNIMP

>       select XLNX_ZDMA

>       select XLNX_ZYNQMP

> +    select OR_IRQ

>   

>   config NPCM7XX

>       bool

> 


Reviewed-by: Thomas Huth <thuth@redhat.com>

Patch

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 647b5c8b43..528f71bb9d 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -368,6 +368,7 @@  config XLNX_VERSAL
     select UNIMP
     select XLNX_ZDMA
     select XLNX_ZYNQMP
+    select OR_IRQ
 
 config NPCM7XX
     bool