[net-next,2/7] ethtool: Document correct attribute type

Message ID	20210622065052.2545107-3-idosch@idosch.org
State	New
Headers	show Return-Path: <netdev-owner@kernel.org> From: Ido Schimmel <idosch@idosch.org> To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch, vladyslavt@nvidia.com, mkubecek@suse.cz, moshe@nvidia.com, mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com> Subject: [PATCH net-next 2/7] ethtool: Document correct attribute type Date: Tue, 22 Jun 2021 09:50:47 +0300 Message-Id: <20210622065052.2545107-3-idosch@idosch.org> In-Reply-To: <20210622065052.2545107-1-idosch@idosch.org> References: <20210622065052.2545107-1-idosch@idosch.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	ethtool: Module EEPROM API improvements \| expand [net-next,0/7] ethtool: Module EEPROM API improvements [net-next,1/7] ethtool: Use correct command name in title [net-next,2/7] ethtool: Document correct attribute type [net-next,3/7] ethtool: Decrease size of module EEPROM get policy array [net-next,4/7] ethtool: Document behavior when module EEPROM bank attribute is omitted [net-next,5/7] ethtool: Use kernel data types for internal EEPROM struct [net-next,6/7] ethtool: Validate module EEPROM length as part of policy [net-next,7/7] ethtool: Validate module EEPROM offset as part of policy

Message ID

20210622065052.2545107-3-idosch@idosch.org

State

New

Headers

From: Ido Schimmel <idosch@idosch.org>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch,
	vladyslavt@nvidia.com, mkubecek@suse.cz, moshe@nvidia.com,
	mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 2/7] ethtool: Document correct attribute type
Date: Tue, 22 Jun 2021 09:50:47 +0300
Message-Id: <20210622065052.2545107-3-idosch@idosch.org>
In-Reply-To: <20210622065052.2545107-1-idosch@idosch.org>
References: <20210622065052.2545107-1-idosch@idosch.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

ethtool: Module EEPROM API improvements | expand

Commit Message

Ido Schimmel June 22, 2021, 6:50 a.m. UTC

From: Ido Schimmel <idosch@nvidia.com>

'ETHTOOL_A_MODULE_EEPROM_DATA' is a binary attribute, not a nested one.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 Documentation/networking/ethtool-netlink.rst | 2 +-
 include/uapi/linux/ethtool_netlink.h         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
index c3600f9c8988..8ae644f800f0 100644
--- a/Documentation/networking/ethtool-netlink.rst
+++ b/Documentation/networking/ethtool-netlink.rst
@@ -1388,7 +1388,7 @@  Kernel response contents:
  +---------------------------------------------+--------+---------------------+
  | ``ETHTOOL_A_MODULE_EEPROM_HEADER``          | nested | reply header        |
  +---------------------------------------------+--------+---------------------+
- | ``ETHTOOL_A_MODULE_EEPROM_DATA``            | nested | array of bytes from |
+ | ``ETHTOOL_A_MODULE_EEPROM_DATA``            | binary | array of bytes from |
  |                                             |        | module EEPROM       |
  +---------------------------------------------+--------+---------------------+
 
diff --git a/include/uapi/linux/ethtool_netlink.h b/include/uapi/linux/ethtool_netlink.h
index 825cfda1c5d5..c7135c9c37a5 100644
--- a/include/uapi/linux/ethtool_netlink.h
+++ b/include/uapi/linux/ethtool_netlink.h
@@ -675,7 +675,7 @@  enum {
 	ETHTOOL_A_MODULE_EEPROM_PAGE,			/* u8 */
 	ETHTOOL_A_MODULE_EEPROM_BANK,			/* u8 */
 	ETHTOOL_A_MODULE_EEPROM_I2C_ADDRESS,		/* u8 */
-	ETHTOOL_A_MODULE_EEPROM_DATA,			/* nested */
+	ETHTOOL_A_MODULE_EEPROM_DATA,			/* binary */
 
 	__ETHTOOL_A_MODULE_EEPROM_CNT,
 	ETHTOOL_A_MODULE_EEPROM_MAX = (__ETHTOOL_A_MODULE_EEPROM_CNT - 1)

[net-next,2/7] ethtool: Document correct attribute type

Commit Message

Patch