diff mbox series

[v3,05/13] arm64: dts: qcom: sc7180: Use QMP binding to control load state

Message ID 1624560727-6870-6-git-send-email-sibis@codeaurora.org
State Superseded
Headers show
Series Use qmp_send to update co-processor load state | expand

Commit Message

Sibi Sankar June 24, 2021, 6:51 p.m. UTC 
Use the Qualcomm Mailbox Protocol (QMP) binding to control the load
state resources on SC7180 SoCs and drop deprecated power-domains exposed
by AOSS QMP node.

Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Matthias Kaehlcke June 25, 2021, 9:35 p.m. UTC | #1 
On Fri, Jun 25, 2021 at 12:21:59AM +0530, Sibi Sankar wrote:
> Subject: arm64: dts: qcom: sc7180: Use QMP binding to control load state


nit: s/binding //

> Use the Qualcomm Mailbox Protocol (QMP) binding to control the load


ditto

same for other DT patches if you re-spin

> state resources on SC7180 SoCs and drop deprecated power-domains exposed

> by AOSS QMP node.

> 

> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>

> Reviewed-by: Stephen Boyd <swboyd@chromium.org>


Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Sibi Sankar June 30, 2021, 7:52 p.m. UTC | #2 
On 2021-06-26 03:05, Matthias Kaehlcke wrote:
> On Fri, Jun 25, 2021 at 12:21:59AM +0530, Sibi Sankar wrote:

>> Subject: arm64: dts: qcom: sc7180: Use QMP binding to control load 

>> state

> 

> nit: s/binding //

> 

>> Use the Qualcomm Mailbox Protocol (QMP) binding to control the load

> 

> ditto

> 

> same for other DT patches if you re-spin


sure, I fix this up in the re-spin
that I base on top of Bjorn's aoss-qmp
yaml conversion series.

> 

>> state resources on SC7180 SoCs and drop deprecated power-domains 

>> exposed

>> by AOSS QMP node.

>> 

>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>

>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

> 

> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index a5d58eb92896..d3e5b67afcb4 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -15,7 +15,6 @@ 
 #include <dt-bindings/interconnect/qcom,sc7180.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/phy/phy-qcom-qusb2.h>
-#include <dt-bindings/power/qcom-aoss-qmp.h>
 #include <dt-bindings/power/qcom-rpmpd.h>
 #include <dt-bindings/reset/qcom,sdm845-aoss.h>
 #include <dt-bindings/reset/qcom,sdm845-pdc.h>
@@ -1893,14 +1892,15 @@ 
 			clock-names = "iface", "bus", "nav", "snoc_axi",
 				      "mnoc_axi", "xo";
 
-			power-domains = <&aoss_qmp AOSS_QMP_LS_MODEM>,
-					<&rpmhpd SC7180_CX>,
+			power-domains = <&rpmhpd SC7180_CX>,
 					<&rpmhpd SC7180_MX>,
 					<&rpmhpd SC7180_MSS>;
-			power-domain-names = "load_state", "cx", "mx", "mss";
+			power-domain-names = "cx", "mx", "mss";
 
 			memory-region = <&mpss_mem>;
 
+			qcom,qmp = <&aoss_qmp>;
+
 			qcom,smem-states = <&modem_smp2p_out 0>;
 			qcom,smem-state-names = "stop";
 
@@ -3116,7 +3116,6 @@ 
 			mboxes = <&apss_shared 0>;
 
 			#clock-cells = <0>;
-			#power-domain-cells = <1>;
 		};
 
 		spmi_bus: spmi@c440000 {