diff mbox series

[v4,10/11] qla2xxx: Increment EDIF command and completion counts

Message ID 20210624052606.21613-11-njavali@marvell.com
State New
Headers show
Series qla2xxx: Add EDIF support | expand

Commit Message

Nilesh Javali June 24, 2021, 5:26 a.m. UTC
From: Quinn Tran <qutran@marvell.com>

Increment the command and the completion counts.

Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_edif.c | 1 +
 drivers/scsi/qla2xxx/qla_isr.c  | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Hannes Reinecke Aug. 10, 2021, 6:47 a.m. UTC | #1
On 6/24/21 7:26 AM, Nilesh Javali wrote:
> From: Quinn Tran <qutran@marvell.com>

> 

> Increment the command and the completion counts.

> 

> Signed-off-by: Quinn Tran <qutran@marvell.com>

> Signed-off-by: Nilesh Javali <njavali@marvell.com>

> ---

>   drivers/scsi/qla2xxx/qla_edif.c | 1 +

>   drivers/scsi/qla2xxx/qla_isr.c  | 3 +--

>   2 files changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c

> index 8e730cc882e6..ccbe0e1bfcbc 100644

> --- a/drivers/scsi/qla2xxx/qla_edif.c

> +++ b/drivers/scsi/qla2xxx/qla_edif.c

> @@ -2926,6 +2926,7 @@ qla28xx_start_scsi_edif(srb_t *sp)

>   		req->ring_ptr++;

>   	}

>   

> +	sp->qpair->cmd_cnt++;

>   	/* Set chip new ring index. */

>   	wrt_reg_dword(req->req_q_in, req->ring_index);

>   

> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c

> index ce4f93fb4d25..e8928fd83049 100644

> --- a/drivers/scsi/qla2xxx/qla_isr.c

> +++ b/drivers/scsi/qla2xxx/qla_isr.c

> @@ -3192,10 +3192,9 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)

>   		return;

>   	}

>   

> -	sp->qpair->cmd_completion_cnt++;

> -

>   	/* Fast path completion. */

>   	qla_chk_edif_rx_sa_delete_pending(vha, sp, sts24);

> +	sp->qpair->cmd_completion_cnt++;

>   

>   	if (comp_status == CS_COMPLETE && scsi_status == 0) {

>   		qla2x00_process_completed_request(vha, req, handle);

> 

Please fix up the patch description (the patch doesn't add counter 
increments, it just moves them to the correct place).

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
index 8e730cc882e6..ccbe0e1bfcbc 100644
--- a/drivers/scsi/qla2xxx/qla_edif.c
+++ b/drivers/scsi/qla2xxx/qla_edif.c
@@ -2926,6 +2926,7 @@  qla28xx_start_scsi_edif(srb_t *sp)
 		req->ring_ptr++;
 	}
 
+	sp->qpair->cmd_cnt++;
 	/* Set chip new ring index. */
 	wrt_reg_dword(req->req_q_in, req->ring_index);
 
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index ce4f93fb4d25..e8928fd83049 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -3192,10 +3192,9 @@  qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)
 		return;
 	}
 
-	sp->qpair->cmd_completion_cnt++;
-
 	/* Fast path completion. */
 	qla_chk_edif_rx_sa_delete_pending(vha, sp, sts24);
+	sp->qpair->cmd_completion_cnt++;
 
 	if (comp_status == CS_COMPLETE && scsi_status == 0) {
 		qla2x00_process_completed_request(vha, req, handle);