| Message ID | 20210626103856.19816-1-yuehaibing@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | mac80211: Reject zero MAC address in sta_info_insert_check() | expand |
Pls drop this. On 2021/6/26 18:38, YueHaibing wrote: > As commit 52dba8d7d5ab ("mac80211: reject zero MAC address in add station") > said, we don't consider all-zeroes to be a valid MAC address in most places, > so also reject it here. > > Reported-by: syzbot+ef4ca92d9d6f5ba2f880@syzkaller.appspotmail.com > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > net/mac80211/sta_info.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c > index f2fb69da9b6e..3a6887fc9160 100644 > --- a/net/mac80211/sta_info.c > +++ b/net/mac80211/sta_info.c > @@ -547,7 +547,7 @@ static int sta_info_insert_check(struct sta_info *sta) > return -ENETDOWN; > > if (WARN_ON(ether_addr_equal(sta->sta.addr, sdata->vif.addr) || > - is_multicast_ether_addr(sta->sta.addr))) > + is_valid_ether_addr(sta->sta.addr))) > return -EINVAL; > > /* The RCU read lock is required by rhashtable due to >
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index f2fb69da9b6e..3a6887fc9160 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -547,7 +547,7 @@ static int sta_info_insert_check(struct sta_info *sta) return -ENETDOWN; if (WARN_ON(ether_addr_equal(sta->sta.addr, sdata->vif.addr) || - is_multicast_ether_addr(sta->sta.addr))) + is_valid_ether_addr(sta->sta.addr))) return -EINVAL; /* The RCU read lock is required by rhashtable due to
As commit 52dba8d7d5ab ("mac80211: reject zero MAC address in add station") said, we don't consider all-zeroes to be a valid MAC address in most places, so also reject it here. Reported-by: syzbot+ef4ca92d9d6f5ba2f880@syzkaller.appspotmail.com Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- net/mac80211/sta_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)