diff mbox series

[v5,2/3] dt-bindings: reset: mt8195: add toprgu reset-controller head file

Message ID 20210628113730.26107-3-Christine.Zhu@mediatek.com
State Superseded
Headers show
Series [v5,1/3] dt-bindings: mediatek: mt8195: update mtk-wdt document | expand

Commit Message

Christine Zhu June 28, 2021, 11:37 a.m. UTC
From: "Christine Zhu" <Christine.Zhu@mediatek.com>

Add toprgu reset-controller head file for MT8195 platform.

Signed-off-by: Christine Zhu <Christine.Zhu@mediatek.com>
---
 .../reset-controller/mt8195-resets.h          | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 include/dt-bindings/reset-controller/mt8195-resets.h

Comments

Rob Herring July 14, 2021, 1:58 a.m. UTC | #1
On Mon, Jun 28, 2021 at 07:37:30PM +0800, Christine Zhu wrote:
> From: "Christine Zhu" <Christine.Zhu@mediatek.com>

> 

> Add toprgu reset-controller head file for MT8195 platform.


s/head/header/

And the subject too.

> 

> Signed-off-by: Christine Zhu <Christine.Zhu@mediatek.com>

> ---

>  .../reset-controller/mt8195-resets.h          | 29 +++++++++++++++++++

>  1 file changed, 29 insertions(+)

>  create mode 100644 include/dt-bindings/reset-controller/mt8195-resets.h

> 

> diff --git a/include/dt-bindings/reset-controller/mt8195-resets.h b/include/dt-bindings/reset-controller/mt8195-resets.h

> new file mode 100644

> index 000000000000..7ec27a64afc7

> --- /dev/null

> +++ b/include/dt-bindings/reset-controller/mt8195-resets.h

> @@ -0,0 +1,29 @@

> +/* SPDX-License-Identifier: GPL-2.0 */


Dual license please.

> +/*

> + * Copyright (c) 2021 MediaTek Inc.

> + * Author: Crystal Guo <crystal.guo@mediatek.com>


According to the S-o-b and patch author, you are the author.

> + */

> +

> +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT8195

> +#define _DT_BINDINGS_RESET_CONTROLLER_MT8195

> +

> +#define MT8195_TOPRGU_CONN_MCU_SW_RST          0

> +#define MT8195_TOPRGU_INFRA_GRST_SW_RST        1

> +#define MT8195_TOPRGU_APU_SW_RST               2

> +#define MT8195_TOPRGU_INFRA_AO_GRST_SW_RST     6

> +#define MT8195_TOPRGU_MMSYS_SW_RST             7

> +#define MT8195_TOPRGU_MFG_SW_RST               8

> +#define MT8195_TOPRGU_VENC_SW_RST              9

> +#define MT8195_TOPRGU_VDEC_SW_RST              10

> +#define MT8195_TOPRGU_IMG_SW_RST               11

> +#define MT8195_TOPRGU_APMIXEDSYS_SW_RST        13

> +#define MT8195_TOPRGU_AUDIO_SW_RST             14

> +#define MT8195_TOPRGU_CAMSYS_SW_RST            15

> +#define MT8195_TOPRGU_EDPTX_SW_RST             16

> +#define MT8195_TOPRGU_ADSPSYS_SW_RST           21

> +#define MT8195_TOPRGU_DPTX_SW_RST              22

> +#define MT8195_TOPRGU_SPMI_MST_SW_RST          23

> +

> +#define MT8195_TOPRGU_SW_RST_NUM               16

> +

> +#endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8195 */

> -- 

> 2.18.0

> 

>
Guenter Roeck July 30, 2021, 5:09 a.m. UTC | #2
On Mon, Jun 28, 2021 at 07:37:30PM +0800, Christine Zhu wrote:
> From: "Christine Zhu" <Christine.Zhu@mediatek.com>

> 

> Add toprgu reset-controller head file for MT8195 platform.

> 

> Signed-off-by: Christine Zhu <Christine.Zhu@mediatek.com>

> ---

>  .../reset-controller/mt8195-resets.h          | 29 +++++++++++++++++++


There is another patch pending which moves the mtk reset controller
include files to another directory. See [1]. Maybe it would make
sense to use the same directory for this file ?

Thanks,
Guenter

>  1 file changed, 29 insertions(+)

>  create mode 100644 include/dt-bindings/reset-controller/mt8195-resets.h

> 

> diff --git a/include/dt-bindings/reset-controller/mt8195-resets.h b/include/dt-bindings/reset-controller/mt8195-resets.h

> new file mode 100644

> index 000000000000..7ec27a64afc7

> --- /dev/null

> +++ b/include/dt-bindings/reset-controller/mt8195-resets.h

> @@ -0,0 +1,29 @@

> +/* SPDX-License-Identifier: GPL-2.0 */

> +/*

> + * Copyright (c) 2021 MediaTek Inc.

> + * Author: Crystal Guo <crystal.guo@mediatek.com>

> + */

> +

> +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT8195

> +#define _DT_BINDINGS_RESET_CONTROLLER_MT8195

> +

> +#define MT8195_TOPRGU_CONN_MCU_SW_RST          0

> +#define MT8195_TOPRGU_INFRA_GRST_SW_RST        1

> +#define MT8195_TOPRGU_APU_SW_RST               2

> +#define MT8195_TOPRGU_INFRA_AO_GRST_SW_RST     6

> +#define MT8195_TOPRGU_MMSYS_SW_RST             7

> +#define MT8195_TOPRGU_MFG_SW_RST               8

> +#define MT8195_TOPRGU_VENC_SW_RST              9

> +#define MT8195_TOPRGU_VDEC_SW_RST              10

> +#define MT8195_TOPRGU_IMG_SW_RST               11

> +#define MT8195_TOPRGU_APMIXEDSYS_SW_RST        13

> +#define MT8195_TOPRGU_AUDIO_SW_RST             14

> +#define MT8195_TOPRGU_CAMSYS_SW_RST            15

> +#define MT8195_TOPRGU_EDPTX_SW_RST             16

> +#define MT8195_TOPRGU_ADSPSYS_SW_RST           21

> +#define MT8195_TOPRGU_DPTX_SW_RST              22

> +#define MT8195_TOPRGU_SPMI_MST_SW_RST          23

> +

> +#define MT8195_TOPRGU_SW_RST_NUM               16

> +

> +#endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8195 */


[1] https://patchwork.kernel.org/project/linux-watchdog/patch/20210714121116.v2.1.I514d9aafff3a062f751b37d3fea7402f67595b86@changeid/
diff mbox series

Patch

diff --git a/include/dt-bindings/reset-controller/mt8195-resets.h b/include/dt-bindings/reset-controller/mt8195-resets.h
new file mode 100644
index 000000000000..7ec27a64afc7
--- /dev/null
+++ b/include/dt-bindings/reset-controller/mt8195-resets.h
@@ -0,0 +1,29 @@ 
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2021 MediaTek Inc.
+ * Author: Crystal Guo <crystal.guo@mediatek.com>
+ */
+
+#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT8195
+#define _DT_BINDINGS_RESET_CONTROLLER_MT8195
+
+#define MT8195_TOPRGU_CONN_MCU_SW_RST          0
+#define MT8195_TOPRGU_INFRA_GRST_SW_RST        1
+#define MT8195_TOPRGU_APU_SW_RST               2
+#define MT8195_TOPRGU_INFRA_AO_GRST_SW_RST     6
+#define MT8195_TOPRGU_MMSYS_SW_RST             7
+#define MT8195_TOPRGU_MFG_SW_RST               8
+#define MT8195_TOPRGU_VENC_SW_RST              9
+#define MT8195_TOPRGU_VDEC_SW_RST              10
+#define MT8195_TOPRGU_IMG_SW_RST               11
+#define MT8195_TOPRGU_APMIXEDSYS_SW_RST        13
+#define MT8195_TOPRGU_AUDIO_SW_RST             14
+#define MT8195_TOPRGU_CAMSYS_SW_RST            15
+#define MT8195_TOPRGU_EDPTX_SW_RST             16
+#define MT8195_TOPRGU_ADSPSYS_SW_RST           21
+#define MT8195_TOPRGU_DPTX_SW_RST              22
+#define MT8195_TOPRGU_SPMI_MST_SW_RST          23
+
+#define MT8195_TOPRGU_SW_RST_NUM               16
+
+#endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8195 */