| Message ID | 20210630152316.24768-1-hdegoede@redhat.com |
|---|---|
| State | Accepted |
| Commit | 9249c32ec9197e8d34fe5179c9e31668a205db04 |
| Headers | show |
| Series | ACPI / video: Add quirk for the Dell Vostro 3350 | expand |
On Wed, Jun 30, 2021 at 5:23 PM Hans de Goede <hdegoede@redhat.com> wrote: > > The Dell Vostro 3350 ACPI video-bus device reports spurious > ACPI_VIDEO_NOTIFY_CYCLE events resulting in spurious KEY_SWITCHVIDEOMODE > events being reported to userspace (and causing trouble there). > > Add a quirk setting the report_key_events mask to > REPORT_BRIGHTNESS_KEY_EVENTS so that the ACPI_VIDEO_NOTIFY_CYCLE > events will be ignored, while still reporting brightness up/down > hotkey-presses to userspace normally. > > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1911763 > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/acpi/acpi_video.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c > index 0c884020f74b..08a51dd285c4 100644 > --- a/drivers/acpi/acpi_video.c > +++ b/drivers/acpi/acpi_video.c > @@ -540,6 +540,15 @@ static const struct dmi_system_id video_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "Vostro V131"), > }, > }, > + { > + .callback = video_set_report_key_events, > + .driver_data = (void *)((uintptr_t)REPORT_BRIGHTNESS_KEY_EVENTS), > + .ident = "Dell Vostro 3350", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3350"), > + }, > + }, > /* > * Some machines change the brightness themselves when a brightness > * hotkey gets pressed, despite us telling them not to. In this case > -- Applied as 5.14-rc1 material, thanks!
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index 0c884020f74b..08a51dd285c4 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -540,6 +540,15 @@ static const struct dmi_system_id video_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Vostro V131"), }, }, + { + .callback = video_set_report_key_events, + .driver_data = (void *)((uintptr_t)REPORT_BRIGHTNESS_KEY_EVENTS), + .ident = "Dell Vostro 3350", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3350"), + }, + }, /* * Some machines change the brightness themselves when a brightness * hotkey gets pressed, despite us telling them not to. In this case
The Dell Vostro 3350 ACPI video-bus device reports spurious ACPI_VIDEO_NOTIFY_CYCLE events resulting in spurious KEY_SWITCHVIDEOMODE events being reported to userspace (and causing trouble there). Add a quirk setting the report_key_events mask to REPORT_BRIGHTNESS_KEY_EVENTS so that the ACPI_VIDEO_NOTIFY_CYCLE events will be ignored, while still reporting brightness up/down hotkey-presses to userspace normally. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1911763 Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/acpi/acpi_video.c | 9 +++++++++ 1 file changed, 9 insertions(+)