diff mbox

linux-generic: pool: fix missing increment of blkallocs stat

Message ID 1428669170-7854-1-git-send-email-bill.fischofer@linaro.org
State Accepted
Commit 8914536bbb4060f37275b6d494957bf096bafc20
Headers show

Commit Message

Bill Fischofer April 10, 2015, 12:32 p.m. UTC
Fixes Bug https://bugs.linaro.org/show_bug.cgi?id=1455

Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
---
 platform/linux-generic/include/odp_pool_internal.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Maxim Uvarov April 17, 2015, 2:06 p.m. UTC | #1
Patch is good. I'm merging it, but create new bug:
https://bugs.linaro.org/show_bug.cgi?id=1480

to add descriptions to all pool counters to better understand what is 
each counter for.

Thanks,
Maxim.

On 04/10/15 15:32, Bill Fischofer wrote:
> Fixes Bug https://bugs.linaro.org/show_bug.cgi?id=1455
>
> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
> ---
>   platform/linux-generic/include/odp_pool_internal.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/platform/linux-generic/include/odp_pool_internal.h b/platform/linux-generic/include/odp_pool_internal.h
> index feeb284..b6b108f 100644
> --- a/platform/linux-generic/include/odp_pool_internal.h
> +++ b/platform/linux-generic/include/odp_pool_internal.h
> @@ -158,6 +158,7 @@ static inline void *get_blk(struct pool_entry_s *pool)
>   		pool->blk_freelist = ((odp_buf_blk_t *)myhead)->next;
>   		POOL_UNLOCK(&pool->blk_lock);
>   		odp_atomic_dec_u32(&pool->blkcount);
> +		odp_atomic_inc_u64(&pool->blkallocs);
>   	}
>   
>   	return myhead;
diff mbox

Patch

diff --git a/platform/linux-generic/include/odp_pool_internal.h b/platform/linux-generic/include/odp_pool_internal.h
index feeb284..b6b108f 100644
--- a/platform/linux-generic/include/odp_pool_internal.h
+++ b/platform/linux-generic/include/odp_pool_internal.h
@@ -158,6 +158,7 @@  static inline void *get_blk(struct pool_entry_s *pool)
 		pool->blk_freelist = ((odp_buf_blk_t *)myhead)->next;
 		POOL_UNLOCK(&pool->blk_lock);
 		odp_atomic_dec_u32(&pool->blkcount);
+		odp_atomic_inc_u64(&pool->blkallocs);
 	}
 
 	return myhead;