| Message ID | 20210707150157.52328-14-mst@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Hi Michael, On Wed, 7 Jul 2021 at 09:03, Michael S. Tsirkin <mst@redhat.com> wrote: > > From: Mathieu Poirier <mathieu.poirier@linaro.org> > > This patch adds entry for the vhost-user-rng related files. > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > Message-Id: <20210614202842.581640-6-mathieu.poirier@linaro.org> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> The pull request's changelog [1] mentions the addition of the vhost-user-rng feature and patch 13/13 [2] of that same pull request adds an entry in MAINTAINERS. On the flip side the files for the feature [3] are absent from the pull request. As such I see two possibilities: 1) The files for the vhost-user-rng feature should have been part of the pull request but fell through the cracks. 2) The vhost-user-rng feature was added to the pull request by mistake. Please let me know. Thanks, Mathieu [1]. https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01530.html [2]. https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01543.html [3]. https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg03560.html > --- > MAINTAINERS | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index cfbf7ef79b..517f22b2e7 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1949,6 +1949,15 @@ F: include/sysemu/rng*.h > F: backends/rng*.c > F: tests/qtest/virtio-rng-test.c > > +vhost-user-rng > +M: Mathieu Poirier <mathieu.poirier@linaro.org> > +S: Supported > +F: docs/tools/vhost-user-rng.rst > +F: hw/virtio/vhost-user-rng.c > +F: hw/virtio/vhost-user-rng-pci.c > +F: include/hw/virtio/vhost-user-rng.h > +F: tools/vhost-user-rng/* > + > virtio-crypto > M: Gonglei <arei.gonglei@huawei.com> > S: Supported > -- > MST >
On Thu, Jul 08, 2021 at 04:01:05PM -0600, Mathieu Poirier wrote: > Hi Michael, > > On Wed, 7 Jul 2021 at 09:03, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > From: Mathieu Poirier <mathieu.poirier@linaro.org> > > > > This patch adds entry for the vhost-user-rng related files. > > > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > Message-Id: <20210614202842.581640-6-mathieu.poirier@linaro.org> > > Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > The pull request's changelog [1] mentions the addition of the > vhost-user-rng feature and patch 13/13 [2] of that same pull request > adds an entry in MAINTAINERS. On the flip side the files for the > feature [3] are absent from the pull request. As such I see two > possibilities: > > 1) The files for the vhost-user-rng feature should have been part of > the pull request but fell through the cracks. > 2) The vhost-user-rng feature was added to the pull request by mistake. > > Please let me know. > > Thanks, > Mathieu > > [1]. https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01530.html > [2]. https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01543.html > [3]. https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg03560.html The files fell through the cracks. Will pick for the next pull. Thanks for reporting this! > > --- > > MAINTAINERS | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index cfbf7ef79b..517f22b2e7 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1949,6 +1949,15 @@ F: include/sysemu/rng*.h > > F: backends/rng*.c > > F: tests/qtest/virtio-rng-test.c > > > > +vhost-user-rng > > +M: Mathieu Poirier <mathieu.poirier@linaro.org> > > +S: Supported > > +F: docs/tools/vhost-user-rng.rst > > +F: hw/virtio/vhost-user-rng.c > > +F: hw/virtio/vhost-user-rng-pci.c > > +F: include/hw/virtio/vhost-user-rng.h > > +F: tools/vhost-user-rng/* > > + > > virtio-crypto > > M: Gonglei <arei.gonglei@huawei.com> > > S: Supported > > -- > > MST > >
On Fri, Jul 09, 2021 at 02:58:32AM -0400, Michael S. Tsirkin wrote: > On Thu, Jul 08, 2021 at 04:01:05PM -0600, Mathieu Poirier wrote: > > Hi Michael, > > > > On Wed, 7 Jul 2021 at 09:03, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > From: Mathieu Poirier <mathieu.poirier@linaro.org> > > > > > > This patch adds entry for the vhost-user-rng related files. > > > > > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > > Message-Id: <20210614202842.581640-6-mathieu.poirier@linaro.org> > > > Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > > > The pull request's changelog [1] mentions the addition of the > > vhost-user-rng feature and patch 13/13 [2] of that same pull request > > adds an entry in MAINTAINERS. On the flip side the files for the > > feature [3] are absent from the pull request. As such I see two > > possibilities: > > > > 1) The files for the vhost-user-rng feature should have been part of > > the pull request but fell through the cracks. > > 2) The vhost-user-rng feature was added to the pull request by mistake. > > > > Please let me know. > > > > Thanks, > > Mathieu > > > > [1]. https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01530.html > > [2]. https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01543.html > > [3]. https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg03560.html > > > The files fell through the cracks. Will pick for the next pull. Thanks > for reporting this! > Oh no I was too hasty. I dropped vhost-user-rng because of the build issue I reported but kept the maintainers entry by mistake and then saw it and included in the commit log. So it's 2. It's harmless so I guess I won't redo the pull request but please send a new version addressing the doc build issue asap so I can include the files themselves. Thanks! > > > --- > > > MAINTAINERS | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index cfbf7ef79b..517f22b2e7 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -1949,6 +1949,15 @@ F: include/sysemu/rng*.h > > > F: backends/rng*.c > > > F: tests/qtest/virtio-rng-test.c > > > > > > +vhost-user-rng > > > +M: Mathieu Poirier <mathieu.poirier@linaro.org> > > > +S: Supported > > > +F: docs/tools/vhost-user-rng.rst > > > +F: hw/virtio/vhost-user-rng.c > > > +F: hw/virtio/vhost-user-rng-pci.c > > > +F: include/hw/virtio/vhost-user-rng.h > > > +F: tools/vhost-user-rng/* > > > + > > > virtio-crypto > > > M: Gonglei <arei.gonglei@huawei.com> > > > S: Supported > > > -- > > > MST > > >
diff --git a/MAINTAINERS b/MAINTAINERS index cfbf7ef79b..517f22b2e7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1949,6 +1949,15 @@ F: include/sysemu/rng*.h F: backends/rng*.c F: tests/qtest/virtio-rng-test.c +vhost-user-rng +M: Mathieu Poirier <mathieu.poirier@linaro.org> +S: Supported +F: docs/tools/vhost-user-rng.rst +F: hw/virtio/vhost-user-rng.c +F: hw/virtio/vhost-user-rng-pci.c +F: include/hw/virtio/vhost-user-rng.h +F: tools/vhost-user-rng/* + virtio-crypto M: Gonglei <arei.gonglei@huawei.com> S: Supported