diff mbox series

drm/msm/dp: Remove unused variable

Message ID 20210709024834.29680-1-jrdr.linux@gmail.com
State Accepted
Commit 5752d58c4e0fe09cbc7a76a3dd05c445a0b5c82e
Headers show
Series drm/msm/dp: Remove unused variable | expand

Commit Message

Souptick Joarder July 9, 2021, 2:48 a.m. UTC
Kernel test roobot throws below warning ->

drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
warning: variable 'drm' set but not used [-Wunused-but-set-variable]

Removed unused variable drm.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/gpu/drm/msm/dp/dp_display.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Abhinav Kumar July 9, 2021, 3:10 a.m. UTC | #1
On 2021-07-08 19:48, Souptick Joarder wrote:
> Kernel test roobot throws below warning ->
> 
> drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
> warning: variable 'drm' set but not used [-Wunused-but-set-variable]
> 
> Removed unused variable drm.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/dp/dp_display.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> b/drivers/gpu/drm/msm/dp/dp_display.c
> index 051c1be1de7e..d42635a86d20 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -1014,10 +1014,8 @@ int dp_display_get_test_bpp(struct msm_dp *dp)
>  void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp 
> *dp)
>  {
>  	struct dp_display_private *dp_display;
> -	struct drm_device *drm;
> 
>  	dp_display = container_of(dp, struct dp_display_private, dp_display);
> -	drm = dp->drm_dev;
> 
>  	/*
>  	 * if we are reading registers we need the link clocks to be on
Stephen Boyd July 14, 2021, 9:39 p.m. UTC | #2
Quoting Souptick Joarder (2021-07-08 19:48:34)
> Kernel test roobot throws below warning ->

>

> drivers/gpu/drm/msm/dp/dp_display.c:1017:21:

> warning: variable 'drm' set but not used [-Wunused-but-set-variable]

>

> Removed unused variable drm.

>

> Reported-by: kernel test robot <lkp@intel.com>

> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

> ---


Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Souptick Joarder Aug. 2, 2021, 2:46 p.m. UTC | #3
On Thu, Jul 15, 2021 at 3:09 AM Stephen Boyd <swboyd@chromium.org> wrote:
>

> Quoting Souptick Joarder (2021-07-08 19:48:34)

> > Kernel test roobot throws below warning ->

> >

> > drivers/gpu/drm/msm/dp/dp_display.c:1017:21:

> > warning: variable 'drm' set but not used [-Wunused-but-set-variable]

> >

> > Removed unused variable drm.

> >


Can we get this in queue for 5.15, if no further comment ?


> > Reported-by: kernel test robot <lkp@intel.com>

> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

> > ---

>

> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 051c1be1de7e..d42635a86d20 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -1014,10 +1014,8 @@  int dp_display_get_test_bpp(struct msm_dp *dp)
 void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp)
 {
 	struct dp_display_private *dp_display;
-	struct drm_device *drm;
 
 	dp_display = container_of(dp, struct dp_display_private, dp_display);
-	drm = dp->drm_dev;
 
 	/*
 	 * if we are reading registers we need the link clocks to be on